Skip to content

[microfrontends] Guard local proxy error responses after headers sent #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plmrry wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[microfrontends] Guard local proxy error responses after headers sent #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d68d1
[local-proxy] fix: prevent writing response after headers are sent in…
plmrry May 24, 2026
d9e8413
add comments
plmrry May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/microfrontends/src/bin/local-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,15 @@ export class LocalProxy {
this.proxy = Server.createProxyServer({ secure: true });
this.proxy.on('error', (err, req, res) => {
if (res instanceof http.ServerResponse) {
/** Already closed; nothing left to send. */
if (res.destroyed || res.writableEnded) return;

/** Headers are committed; abort instead of writing a 500. */
if (res.headersSent) {
res.destroy(err);
return;
}

res.writeHead(500, {
'Content-Type': 'text/plain',
});
Expand Down Expand Up @@ -701,6 +710,16 @@ export class LocalProxy {
req.pipe(proxyReq);
proxyReq.on('error', (err) => {
logger.error('Proxy request error: ', err);

/** Already closed; nothing left to send. */
if (res.destroyed || res.writableEnded) return;

/** Headers are committed; abort instead of writing a 500. */
if (res.headersSent) {
res.destroy(err);
return;
}

res.writeHead(500, { 'Content-Type': 'text/plain' });
res.end(
`Error proxying request for ${target.application} to ${hostname}:${port}${path}`,
Expand Down
Loading