added flags.json and logger_config.yaml to container image.#20
Merged
sloppycoder merged 1 commit intomainfrom May 9, 2025
Merged
added flags.json and logger_config.yaml to container image.#20sloppycoder merged 1 commit intomainfrom
sloppycoder merged 1 commit intomainfrom
Conversation
check requirements when uv.lock is changed. doc update
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration files to manage feature flags and logger settings and updates related tooling.
- Updated the README.md to document the initialization of the feature flag provider.
- Revised the pre-commit configuration to trigger requirements updates when either pyproject.toml or uv.lock changes.
- Modified the .dockerignore file to explicitly include flags JSON files and logger configuration in the container image.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| {{cookiecutter.project_slug}}/README.md | Updated documentation for settings.py to mention feature flag provider initialization. |
| {{cookiecutter.project_slug}}/.pre-commit-config.yaml | Extended file matching to include uv.lock changes for requirement updates. |
| {{cookiecutter.project_slug}}/.dockerignore | Added inclusion patterns for flags JSON files and logger_config.yaml to the container image. |
Comments suppressed due to low confidence (1)
{{cookiecutter.project_slug}}/.dockerignore:11
- [nitpick] Verify that the pattern '!flags*.json' accurately targets only the intended flag files and does not inadvertently include other JSON files that should remain excluded.
!flags*.json
| | ------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | [main.py](main.py) | main point for FastAPI | | ||
| | [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set | | ||
| | [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. | |
There was a problem hiding this comment.
[nitpick] Consider adding a brief note or a link to additional documentation explaining the feature flag provider configuration to help future maintainers.
Suggested change
| | [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. | | |
| | [settings.py](settings.py) | Reads settings from a file specified by `APP_SETTINGS_ENV` or `.env` if it's not set. Also initializes the feature flag provider. For more details on configuring the feature flag provider, see [Feature Flag Provider Documentation](https://example.com/feature-flag-docs). | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check requirements when uv.lock is changed.
doc update