Skip to content

added flags.json and logger_config.yaml to container image. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sloppycoder merged 1 commit into from
May 9, 2025
Merged

added flags.json and logger_config.yaml to container image. #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions {{cookiecutter.project_slug}}/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
!*.py
!migrations/
!{{ cookiecutter.pkg_name }}
!flags*.json
!logger_config.yaml
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ repos:
name: ensure requirements.txt is up-to-date
entry: bash -c 'uv pip compile pyproject.toml -o requirements.txt > /dev/null && git diff --exit-code requirements.txt > /dev/null'
language: system
files: ^pyproject\.toml$
files: ^(pyproject\.toml|uv\.lock)$
pass_filenames: false

- id: pyright
Expand Down
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pytest -v
| File | Purpose |
| ------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [main.py](main.py) | main point for FastAPI |
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set |
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. |
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief note or a link to additional documentation explaining the feature flag provider configuration to help future maintainers.

Suggested change
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. |
| [settings.py](settings.py) | Reads settings from a file specified by `APP_SETTINGS_ENV` or `.env` if it's not set. Also initializes the feature flag provider. For more details on configuring the feature flag provider, see [Feature Flag Provider Documentation](https://example.com/feature-flag-docs). |

Copilot uses AI. Check for mistakes.
| [security.py](security.py) | verify JWT token using keys from a [JWKS](https://datatracker.ietf.org/doc/html/rfc7517) endpoint |
| [database.py](database.py) | provides both sync and async database. available only if sqlmodel is selected. setup |
| [tests/conftest.py](tests/conftest.py) | [pytest](https://docs.pytest.org/en/stable/) test setup (https://docs.pytest.org/en/stable/) test setup and fixtures, including http client, test database setup and seeding with data, etc | |
Expand Down
Loading