Skip to content

fix: diagnose unsupported stored configuration with safe recovery - #642

Merged
efraespada merged 4 commits into
developfrom
bugfix/635-improve-diagnostics-and-recovery-for-unsupported-pr-configuration-schemas
Oct 21, 2026
Merged

efraespada merged 4 commits into
developfrom
bugfix/635-improve-diagnostics-and-recovery-for-unsupported-pr-configuration-schemas

Conversation

@efraespada

@efraespada efraespada commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Unsupported stored Copilot configuration now fails as a nonretryable configuration.invalid error with its correlation reference preserved and actionable recovery guidance in the failure annotation and Job Summary. Strict schema validation remains in place, while absent and current-schema configurations retain their existing behavior.

What changed

  • Classify missing, unsupported, and malformed stored configuration with bounded diagnostic facts and the required schema version.
  • Preserve configuration error code, retryability, and correlation identity through the final Action boundary; publish the failure to the Job Summary.
  • Provide localized recovery guidance that distinguishes obsolete unmanaged markers from potentially valuable managed state, without rewriting configuration during validation.
  • Keep GitHub authorization and provider read failures in their corresponding error categories, and update related documentation and specification catalog evidence.

Validation

  • pnpm run test:coverage: 687 suites passed; 11,196 tests passed; 35 skipped. Coverage budgets and the setup acceptance validator passed; overall coverage was 97.77% lines and 94.24% branches, with 100% coverage for the configuration reader.
  • Build, generated-bundle and package validation, type checking, lint, architecture and privacy guards, workflow, agent-documentation, documentation, and specification validators passed.
  • Deterministic cases cover stored-state validation, provider errors, localized presentation, summary-write failure, unchanged replay, and unlinked-PR setup after deliberate obsolete-marker removal.
  • Native replay of the new failure and verification of the published documentation anchor remain pending deployment.

Review notes

  • Native replay and the published documentation anchor still need verification after deployment.

Closes #635

@docs-page

docs-page Bot commented Oct 21, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~642

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 21, 2026 09:20
@vypbot vypbot added this to vypdev Oct 21, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 21, 2026
@vypbot
vypbot changed the base branch from develop to master October 21, 2026 09:20
@vypbot
vypbot changed the base branch from master to develop October 21, 2026 09:21
@vypbot vypbot added size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. 90% Progress: 90% state:reviewing and removed state:ai-processing labels Oct 21, 2026
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: aafb613d0c97; base: 78861c2d7e7b; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (274db40) to head (aafb613).
⚠️ Report is 1571 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
+ Coverage    90.94%   94.11%   +3.16%     
===========================================
  Files          135      950     +815     
  Lines         6251    30588   +24337     
  Branches      1338     8980    +7642     
===========================================
+ Hits          5685    28788   +23103     
- Misses         172      704     +532     
- Partials       394     1096     +702     
Files with missing lines Coverage Δ
src/actions/github_action.ts 95.68% <100.00%> (+13.76%) ⬆️
...tion/policies/application_error_message_catalog.ts 100.00% <100.00%> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
src/data/repository/github/github_error_policy.ts 100.00% <100.00%> (ø)
.../data/repository/issue/issue_content_repository.ts 91.04% <100.00%> (ø)
src/manager/description/configuration_handler.ts 100.00% <100.00%> (ø)

... and 1010 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada marked this pull request as ready for review October 21, 2026 09:41
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on aafb613.

Pull request · Verified commit · Workflow run

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch --from develop

@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/635-improve-diagnostics-and-recovery-for-unsupported-pr-configuration-schemas and pushed as aa9bb011f2d99917634610f408f07914044e880e.

6 verification checks passed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch --from develop --no-agent

@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/635-improve-diagnostics-and-recovery-for-unsupported-pr-configuration-schemas and pushed as 69e5f8fbbed973cf40551f597b91ae0b44717a08.

6 verification checks passed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch --from develop

@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/635-improve-diagnostics-and-recovery-for-unsupported-pr-configuration-schemas and pushed as aafb613d0c970d441b3dc61929f8f1936e0b8486.

6 verification checks passed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Improve diagnostics and recovery for unsupported PR configuration schemas

3 participants