Repository navigation
feat(#656): generate verification setup actions and expose wizard activation - #657
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on6dd7963. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit f21020d was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Parent replacement can redirect starter creation outside the repository —
src/infrastructure/setup_verification_action.ts:46
Bugbot: review complete
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #657 +/- ##
===========================================
+ Coverage 90.94% 94.12% +3.17%
===========================================
Files 135 972 +837
Lines 6251 31478 +25227
Branches 1338 9240 +7902
===========================================
+ Hits 5685 29628 +23943
- Misses 172 715 +543
- Partials 394 1135 +741
🚀 New features to boost your workflow:
|
|
/copilot sync-branch --no-agent |
…eserve-consumer-actions-and-expose-wizard-activation
Branch synchronized
6 verification checks passed. |
|
/copilot findings |
Setup now creates
.github/actions/copilot-verification-setup/action.ymlwhen it is missing and exposes the existingVERIFICATION_SETUPboolean in the shared terminal/web assistant. Existing project actions and auxiliary files remain consumer-owned and are preserved through installation, workflow upgrades, deselection and batch maintenance. The packaged composite starter fails with customization instructions until the project owner replaces its placeholder.The review shows create/preserve/blocked, requested activation and the configured trusted main branch. Apply rejects unsafe paths and stale creation plans; exclusive file creation cannot truncate a concurrent file. The upgrade guide separates CLI versions, Action refs and committed workflow updates, and explains customization, trusted-main review, activation, organization reuse/overrides and rollback. Generated files or installer PRs do not establish runtime readiness.
Validation: 707 local suites pass (11,607 tests passed; 35 existing skips), plus two supplemental platform-neutral race regressions, for 99 new VSO cases overall. The new summary policy is exhaustive; the safe file adapter and every repository coverage budget pass. Typecheck, lint, Svelte check, specification/catalog, documentation, workflow, generated-bundle and npm-package validators pass; extracted-package smoke passes. Credential-free browser review covered 1280 px and 375 px, including Spanish; SSR contracts cover all four supported locales.
Review follow-up pins directory traversal and verifies retained descriptor identities so replacing a checked parent cannot redirect creation. Controlled races assert that no transient file appears at the external target. Bundles are generated with dependencies installed inside the isolated checkout and two consecutive builds were identical.
Closes #656. Final-head GitHub checks and review findings must be clear before merging into
develop. This PR does not publish a release or install changes into consumer repositories.