Add editable keybinding for toggling the conversation details panel.#9837
Conversation
89ad5df to
c580d8c
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds an editable Warp AI keybinding for toggling the conversation details panel and exposes a keymap context flag when the panel can be shown.
Concerns
- The new terminal action binding is registered for all targets, but the WASM details panel is controlled by workspace-level transcript panel state, so the shortcut can be active while toggling terminal state that is never rendered.
- This is a user-visible keybinding/settings change, but the PR does not include screenshots or a video demonstrating the configured shortcut and panel toggle behavior end to end.
- The changelog entry has a minor typo:
panelcanshould bepanel can.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| app.register_editable_bindings([EditableBinding::new( | ||
| "terminal:toggle_conversation_details_panel", | ||
| "Toggle Conversation Details Panel", | ||
| TerminalAction::ToggleConversationDetailsPanel, |
There was a problem hiding this comment.
|
|
||
| app.register_editable_bindings([EditableBinding::new( | ||
| "terminal:toggle_conversation_details_panel", | ||
| "Toggle Conversation Details Panel", |
There was a problem hiding this comment.
Description
WISOTT. Follows precedent for defining keys in the keymap context and uses existing function for determining whether this keybinding should be active.
Defaults to unset - I wasn't sure of a good keybind for this and don't think it warrants a default.
Testing
Ran locally, set a keybinding (cmd + alt + I), and then observed toggle behavior.
Agent Mode
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: The conversation details panelcan now be opened and closed with a configurable keyboard shortcut.