Skip to content

Add editable keybinding for toggling the conversation details panel.#9837

Open
liliwilson wants to merge 1 commit intooz-agent/APP-3595/conversation-details-panel-localfrom
lili/add-keybinding-for-details-panel
Open

Add editable keybinding for toggling the conversation details panel.#9837
liliwilson wants to merge 1 commit intooz-agent/APP-3595/conversation-details-panel-localfrom
lili/add-keybinding-for-details-panel

Conversation

@liliwilson
Copy link
Copy Markdown
Contributor

@liliwilson liliwilson commented May 1, 2026

Description

WISOTT. Follows precedent for defining keys in the keymap context and uses existing function for determining whether this keybinding should be active.

Defaults to unset - I wasn't sure of a good keybind for this and don't think it warrants a default.

Testing

Ran locally, set a keybinding (cmd + alt + I), and then observed toggle behavior.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-IMPROVEMENT: The conversation details panelcan now be opened and closed with a configurable keyboard shortcut.

@cla-bot cla-bot Bot added the cla-signed label May 1, 2026
@liliwilson liliwilson force-pushed the lili/add-keybinding-for-details-panel branch from 89ad5df to c580d8c Compare May 1, 2026 18:46
@liliwilson liliwilson requested a review from seemeroland May 1, 2026 18:47
@liliwilson liliwilson marked this pull request as ready for review May 1, 2026 18:47
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 1, 2026

@liliwilson

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds an editable Warp AI keybinding for toggling the conversation details panel and exposes a keymap context flag when the panel can be shown.

Concerns

  • The new terminal action binding is registered for all targets, but the WASM details panel is controlled by workspace-level transcript panel state, so the shortcut can be active while toggling terminal state that is never rendered.
  • This is a user-visible keybinding/settings change, but the PR does not include screenshots or a video demonstrating the configured shortcut and panel toggle behavior end to end.
  • The changelog entry has a minor typo: panelcan should be panel can.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

app.register_editable_bindings([EditableBinding::new(
"terminal:toggle_conversation_details_panel",
"Toggle Conversation Details Panel",
TerminalAction::ToggleConversationDetailsPanel,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This binding is registered on all targets but dispatches the terminal-view toggle; on WASM the details panel is rendered from workspace transcript-panel state, so the shortcut can be active while toggling state that is never rendered. Gate this binding to non-WASM or route the web path through the workspace toggle.


app.register_editable_bindings([EditableBinding::new(
"terminal:toggle_conversation_details_panel",
"Toggle Conversation Details Panel",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This adds a user-visible keybinding/settings entry; for faster review, please upload screenshots or a video of the feature working end to end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant