Skip to content

Add editable keybinding for toggling the conversation details panel. #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liliwilson wants to merge 1 commit into
base: oz-agent/APP-3595/conversation-details-panel-local
Choose a base branch
from
+15 −0
Open

Add editable keybinding for toggling the conversation details panel. #9837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/terminal/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26244,6 +26244,12 @@ impl View for TerminalView {
context.set.insert("InsideRepository");
}

if self.can_show_conversation_details_ui_from_model(&model_lock, app) {
context
.set
.insert(init::CAN_SHOW_CONVERSATION_DETAILS_KEY);
}

let active_conversation = if FeatureFlag::AgentView.is_enabled() {
self.agent_view_controller
.as_ref(app)
Expand Down
9 changes: 9 additions & 0 deletions app/src/terminal/view/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ pub const INPUT_BOX_VISIBLE_KEY: &str = "InputVisible";
pub const KEYBOARD_PROTOCOL_ENABLED_KEY: &str = "KeyboardProtocolEnabled";
pub const CLI_AGENT_SESSION_ACTIVE_KEY: &str = "CLIAgentSessionActive";
pub const ROOT_CLOUD_MODE_PANE_KEY: &str = "RootCloudModePane";
pub const CAN_SHOW_CONVERSATION_DETAILS_KEY: &str = "CanShowConversationDetails";

/// Some keybindings will do different things in different contexts. We break
/// these into their own function to ensure we pay special attention to
Expand Down Expand Up @@ -1073,6 +1074,14 @@ pub fn init(app: &mut AppContext) {
.with_enabled(|| FeatureFlag::Projects.is_enabled())
.with_context_predicate(id!("Workspace") & id!(flags::IS_ANY_AI_ENABLED))]);

app.register_editable_bindings([EditableBinding::new(
"terminal:toggle_conversation_details_panel",
"Toggle Conversation Details Panel",
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This adds a user-visible keybinding/settings entry; for faster review, please upload screenshots or a video of the feature working end to end.

TerminalAction::ToggleConversationDetailsPanel,
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This binding is registered on all targets but dispatches the terminal-view toggle; on WASM the details panel is rendered from workspace transcript-panel state, so the shortcut can be active while toggling state that is never rendered. Gate this binding to non-WASM or route the web path through the workspace toggle.

)
.with_group(bindings::BindingGroup::WarpAi.as_str())
.with_context_predicate(id!("Terminal") & id!(CAN_SHOW_CONVERSATION_DETAILS_KEY))]);

// Register bindings for starting a new cloud agent conversation.
{
app.register_fixed_bindings([FixedBinding::new_per_platform(
Expand Down