Skip to content

refactor: remove redundant type & fix nested template literals#4464

Merged
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-code
May 22, 2025
Merged

refactor: remove redundant type & fix nested template literals#4464
alexander-akait merged 1 commit intowebpack:masterfrom
noritaka1166:refactor-code

Conversation

@noritaka1166
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
no

If relevant, did you update the documentation?
no

Summary

  • remove redundant type
  • fix nested template literals

Does this PR introduce a breaking change?
no

Other information
no

@noritaka1166 noritaka1166 requested a review from a team as a code owner May 22, 2025 09:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (31f634a) to head (7837031).
Report is 238 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4464      +/-   ##
==========================================
- Coverage   90.18%   89.96%   -0.23%     
==========================================
  Files          22        9      -13     
  Lines        1702     1415     -287     
  Branches      491      463      -28     
==========================================
- Hits         1535     1273     -262     
+ Misses        167      142      -25     
Files with missing lines Coverage Δ
packages/webpack-cli/src/plugins/cli-plugin.ts 86.11% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5540430...7837031. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit cd435ab into webpack:master May 22, 2025
54 of 55 checks passed
@noritaka1166 noritaka1166 deleted the refactor-code branch May 23, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants