Skip to content

refactor: remove redundant type & fix nested template literals #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 1 commit into from
May 22, 2025
Merged

refactor: remove redundant type & fix nested template literals #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions packages/webpack-cli/src/plugins/cli-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class CLIPlugin {

setupHelpfulOutput(compiler: Compiler) {
const pluginName = "webpack-cli";
const getCompilationName = () => (compiler.name ? `'${compiler.name}'` : "");
const getCompilationName = () => (compiler.name ? ` '${compiler.name}'` : "");
const logCompilation = (message: string) => {
if (process.env.WEBPACK_CLI_START_FINISH_FORCE_LOG) {
process.stderr.write(message);
Expand All @@ -84,13 +84,11 @@ export class CLIPlugin {
compiler.hooks.run.tap(pluginName, () => {
const name = getCompilationName();

logCompilation(`Compiler${name ? ` ${name}` : ""} starting... `);
logCompilation(`Compiler${name} starting... `);

if (configPath) {
this.logger.log(
`Compiler${name ? ` ${name}` : ""} is using config: ${configPath
.map((path) => `'${path}'`)
.join(", ")}`,
`Compiler${name} is using config: ${configPath.map((path) => `'${path}'`).join(", ")}`,
);
}
});
Expand All @@ -106,10 +104,10 @@ export class CLIPlugin {

const name = getCompilationName();

logCompilation(`Compiler${name ? ` ${name}` : ""} starting... `);
logCompilation(`Compiler${name} starting... `);

if (configPath) {
this.logger.log(`Compiler${name ? ` ${name}` : ""} is using config: '${configPath}'`);
this.logger.log(`Compiler${name} is using config: '${configPath}'`);
}
});

Expand All @@ -125,11 +123,11 @@ export class CLIPlugin {
() => {
const name = getCompilationName();

logCompilation(`Compiler${name ? ` ${name}` : ""} finished`);
logCompilation(`Compiler${name} finished`);

process.nextTick(() => {
if (compiler.watchMode) {
this.logger.log(`Compiler${name ? `${name}` : ""} is watching files for updates...`);
this.logger.log(`Compiler${name} is watching files for updates...`);
}
});
},
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-cli/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ type WebpackDevServerOptions = DevServerConfig &
Argv & {
nodeEnv?: string;
watchOptionsStdin?: boolean;
progress?: boolean | "profile" | undefined;
progress?: boolean | "profile";
analyze?: boolean;
prefetch?: string;
json?: boolean;
Expand Down