Skip to content

feat: make hardcoded UI strings and ARIA labels configurable for i18n/a11y#1

Merged
wfabr merged 4 commits into
mainfrom
copilot/fix-hardcoded-english-strings
Jun 15, 2026
Merged

feat: make hardcoded UI strings and ARIA labels configurable for i18n/a11y#1
wfabr merged 4 commits into
mainfrom
copilot/fix-hardcoded-english-strings

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown

All user-visible strings and ARIA labels in the select components were hardcoded in English, making the library unusable in non-English locales or custom accessibility contexts. This adds overridable properties with English defaults to VscodeSelectBase, VscodeMultiSelect, and VscodeSingleSelect.

New properties

VscodeSelectBase (inherited by both select components)

  • open-button-aria-label — ARIA label on the combobox toggle button (default: "Open the list of options")
  • no-options-text — empty-list placeholder (default: "No options")
  • create-option-prefix — prefix for the creatable entry (default: "Add", renders as Add "typed text")

VscodeMultiSelect

  • selected-text — suffix in the count badge (default: "Selected", renders as "3 Selected")
  • select-all-title — tooltip on the select-all button (default: "Select all")
  • deselect-all-title — tooltip on the deselect-all button (default: "Deselect all")
  • accept-button-text — label on the OK button (default: "OK")

Usage example

<vscode-multi-select
  open-button-aria-label="Öffne die Optionsliste"
  no-options-text="Keine Optionen"
  create-option-prefix="Hinzufügen"
  selected-text="Ausgewählt"
  select-all-title="Alle auswählen"
  deselect-all-title="Alle abwählen"
  accept-button-text="OK"
>
  ...
</vscode-multi-select>

All defaults are unchanged so there is no breaking change.

Copilot AI changed the title [WIP] Fix hardcoded English strings for better localization support feat: make hardcoded UI strings and ARIA labels configurable for i18n/a11y Jun 10, 2026
Copilot finished work on behalf of wfabr June 10, 2026 16:30
Copilot AI requested a review from wfabr June 10, 2026 16:30
@wfabr wfabr marked this pull request as ready for review June 10, 2026 16:48
@wfabr wfabr marked this pull request as ready for review June 15, 2026 09:30
@wfabr wfabr merged commit 4811b36 into main Jun 15, 2026
0 of 6 checks passed
@wfabr

wfabr commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Approved merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants