docs(contributing): point the label source of truth at lib/labels.yml#802
Merged
Conversation
The page linked z-shell/.github/.github/lib/labels.yml, a stale duplicate that is being removed in z-shell/.github#471. The canonical file, and the one scripts/labels-sync.rb actually reads, is lib/labels.yml at that repository's root. The new target already resolves, so the link is correct both before and after the duplicate is deleted.
Deploying zsh with
|
| Latest commit: |
80a3d3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9968c8e2.zsh.pages.dev |
| Branch Preview URL: | https://fix-461-labels-yml-link.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contributing/project-management documentation to point the “canonical label set” link at the actual source-of-truth file in z-shell/.github, avoiding a future dead link when the stale duplicate is removed.
Changes:
- Replace the outdated link to
z-shell/.github/.github/lib/labels.ymlwith the correctz-shell/.github/lib/labels.ymltarget.
ss-o
added a commit
to z-shell/.github
that referenced
this pull request
Jul 21, 2026
Closes #461. Two canonical label files existed and had diverged; every document pointed at .github/lib/labels.yml while labels-sync.rb reads lib/labels.yml, so edits made by following the runbook were ignored without error. They were not equal authorities: root holds 32 labels plus the legacy_migrations and sync_policy blocks, while the .github copy was a bare YAML array of 29 labels with neither, and labels-sync.rb rejects that schema outright. Removes the stale copy and repoints all seven references. A consumer audit across all 86 active repositories found no automation reading either file; the only external reference, a link in z-shell/wiki, was repointed first in z-shell/wiki#802.
This was referenced Jul 21, 2026
ss-o
added a commit
that referenced
this pull request
Jul 22, 2026
main links to z-shell/.github/.github/lib/labels.yml, which became a 404 when that duplicate was removed in z-shell/.github#471. The corrected link already exists on next via #802, but main requires branches to be up to date and its required Trunk Check fails on this 404, so the promotion that would carry the fix is blocked by the fix's absence. Applies the same one-line correction directly to main to break that deadlock. Identical to the change already on next, so the branches converge cleanly. Co-authored-by: Sall <ss-o@users.noreply.github.com>
ss-o
added a commit
that referenced
this pull request
Jul 22, 2026
* docs(zsh-lint): add generated-reference markers (#755) docs(zsh-lint): add generated-reference markers and seed content Re-add the {/* zsh-lint:generated:start/end */} markers to the Zsh Lint ecosystem page so the wiki-docs-sync pipeline from z-shell/zsh-lint has a region to inject into. Seed the region with the current generated Go reference so the first automated sync is a no-op rather than a failure. The marked region is machine-managed — do not hand-edit; it is regenerated from the repo's Go doc comments. Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com> * docs(zsh-lint): sync generated reference (#756) docs(zsh-lint): sync generated reference from zsh-lint * ci(trunk): fix duplicate Trunk Check context blocking PRs (#759) ci(trunk): rename workflow/job to Trunk Code Quality to fix duplicate check context The workflow and job were both named 'Trunk Check', colliding with the check that trunk-io/trunk-action posts (also 'Trunk Check'). Two identically-named check-runs confuse strict branch protection (required context 'Trunk Check'), leaving PRs stuck in BLOCKED even when all checks pass. Renaming to the org-conventional 'Trunk Code Quality' (matching other repos) leaves the action's 'Trunk Check' as the sole required context. Fixes #757. Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com> * docs(packages): drop removed Zsh 5.1.1/5.2.4 from version list The zsh package no longer ships 5.1.1 or 5.2.4 as selectable profiles (z-shell/zsh#14). Remove the two stale 'zi pack' examples so the usage page matches the available manifest profiles. * docs(zsh-lint): move tool documentation into community * docs(zsh-lint): normalize generated reference indentation * ci(workflows): enforce concurrency and permissions rules * ci(workflows): enforce top-level policy blocks * chore(repo): reconcile main content into next * docs(community): align project metadata with Linear * docs(contributing): point the label source of truth at lib/labels.yml (#802) The page linked z-shell/.github/.github/lib/labels.yml, a stale duplicate removed in z-shell/.github#471. The canonical file, and the one labels-sync.rb reads, is lib/labels.yml at that repository's root. Supports z-shell/.github#461. --------- Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports z-shell/.github#461.
What
community/00_contributing/05_project_management.mdxlinked the canonical label set toz-shell/.github/.github/lib/labels.yml. That file is a stale duplicate being removed in z-shell/.github#471.The real source of truth — and the file
scripts/labels-sync.rbactually reads — islib/labels.ymlat that repository's root. It carries 32 labels plus thelegacy_migrationsandsync_policyblocks; the copy being removed was a bare YAML array of 29 labels with neither.Ordering
Safe to merge in either order. The new target already resolves (
HTTP 200), so the link is correct before and after the duplicate is deleted. This PR is what stops the wiki from developing a dead link when it is.This link was found by a consumer audit run before anything was removed — it was the only reference to that file outside
z-shell/.github.