Correct GPU timing readback and transmitted-shadow reconstruction - #156
Draft
proggeramlug wants to merge 2 commits into
Draft
Correct GPU timing readback and transmitted-shadow reconstruction#156proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU profiling on Radeon/Vulkan returned the preceding frame's timestamps, and transmitted shadows reconstructed receiver positions with an incorrectly laid-out inverse camera matrix. The profiler now copies resolved queries in a following submission and rejects incomplete measurements; the shadow pass now uploads the same transposed inverse used by SSR/PT, placing the colored shadow beneath its caster.
The shadow regression isolates direct lighting from asynchronous GI and automatically retains failed captures. Its original camera, light, material, frame counts, and assertions are unchanged. The isolated old implementation fails on Radeon; the correction produces 3,217 affected pixels, and a swapped red/green attenuation control is rejected.
Validation: the profiler implementation passes all 487 shared unit tests, 90 golden tests and remaining enabled local runtime suites, contracts, lint, and the quality lane (25 quality-runner tests). Its current-frame regression rejects all 12 old Vulkan samples and passes on Radeon Vulkan and DX12. Hosted Metal reports the test as ok, but a timestamp-capability early return is possible, so Metal GPU timestamp validation remains unproven. The shadow follow-up at
fa93690passes the complete local shared suite and all 23 hosted checks, including the colored-shadow regression on Metal. The two scheduled physical-hardware jobs remain skipped. Existing ignores and external-scene omissions are explicit in the reports.Both SSGI shader variants were remeasured with the corrected profiler in 20 isolated runs, each with 120 complete GPU frames. The stationary fix adds a median 0.008598 ms at 256 square and 0.043532 ms at 1280x720 for the five probe passes. Earlier timing observations are superseded; image baselines and budgets are unchanged.
Stacked on draft #155. Related: #128, #135, #149, #153. The two Windows portable-image discrepancies, HD temporal stability, representative-scene and other hardware acceptance remain open.
Profiler report | Shadow correction | Raw evidence