Retain raw attachment and capability evidence for image portability - #157
Draft
proggeramlug wants to merge 4 commits into
Draft
Retain raw attachment and capability evidence for image portability#157proggeramlug wants to merge 4 commits into
proggeramlug wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponza and skinned/alpha motion fail the portable image thresholds on Windows while the same canonical scenes pass on hosted Metal. Final PNGs alone cannot identify the first divergent stage, and independently normalized depth previews cannot prove numerical depth equality.
Add a hosted Metal diagnostic lane using SHA-256-pinned Perry 0.5.1182 and the canonical scene commands. Add opt-in
BLOOM_QUALITY_RAW=1export of exact attachment rows, format/dimension/checksum metadata, and the existing raw HDR/material/motion/albedo readback. The lane retains success and failure evidence and separately rejects incomplete or wrong-backend captures; shared-runner timing remains informational.The cutout-input tool makes temporary opaque-card builds, exports exact f32 U/V bits and the original coverage decision, and restores the source and native library afterward. It exposes accepted and rejected nearest-card fragments for comparison across backends.
Hosted shared tests now retain adapter and capability-skip output. This exposed that the Metal profiler test skips because timestamps are unavailable on the Apple Paravirtual device. The prior Metal timestamp-coverage claim is corrected; Radeon Vulkan/DX12 validation is unchanged.
Validation:
98cce62(generated executable is the only dirty path).30e7625; the two scheduled physical-hardware jobs are skipped. Both raw Metal captures pass their visual thresholds. The cutout probes produce 103,644 corresponding masked-card pixels on each backend, and their U/V runs retain identical depth and decision data.Stacked on draft #156. Related: #128, #140, #153. Approved images, thresholds, and performance budgets are unchanged.
Initial raw evidence and investigation report. The exact inputs identify different Bayer phase extents from floating-point
exp2/floor; follow-up draft #158 makes the approved phase grid explicit with integer arithmetic. Its evidence release includes these original inputs, the corrected captures, and the final validation results.