Make cutout coverage phase deterministic across backends - #158
Draft
proggeramlug wants to merge 1 commit into
Draft
Make cutout coverage phase deterministic across backends#158proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponza and skinned/alpha motion failed the approved portable images on Windows because Metal and Vulkan produced different Bayer coverage grids from floating-point
exp2followed byfloor. Exact UV and cutout-input captures locate the difference before TAA; the observed Metal extent predicts every inspected threshold away from integer LOD boundaries.Derive the scene and shadow phase extents from the final source texel index with integer arithmetic. This preserves the approved Metal grid across backends, handles odd texture dimensions and coarse LODs, and leaves alpha sampling and approved images unchanged.
Both focused Windows images now pass on Radeon 760M/Vulkan with matching modern/software-GI settings:
Validation on
662a44f:Stacked on draft #157. Related: #128, #140, #153. Investigation and compatibility rationale.
Published report, raw captures, controls, and checksums.