Use an explicit FXC lane for hosted Windows software rendering - #164
Draft
proggeramlug wants to merge 1 commit into
Draft
Use an explicit FXC lane for hosted Windows software rendering#164proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted Windows shared tests terminate with
0xc0000005before reaching goldens. Local WARP controls reproduce the failure, and a debugger stack identifies the DXIL compute-shader optimizer during virtual-geometry traversal. All ten hierarchy tests pass serially with DXC, while both four-thread DXC controls crash; FXC passes the hierarchy group and complete library controls at four and eight threads.Select DX12/FXC explicitly for the hosted Windows shared lane. Make the remaining ordinary GPU test helpers honor backend and compiler environment options, matching the existing visibility, virtual-geometry and golden helpers. Preserve adapter selection, capability requirements, assertions, thresholds, ignored tests and the ray-query helper's deliberate DXC requirement. The Windows engine's compiler policy is unchanged.
The candidate library suite passes with four threads and explicit FXC (489 passed, one ignored). Complete local shared runs pass under physical DX12/DXC and Vulkan, including all 93 goldens and remaining integration checks. Formatting, strict Clippy, repository contracts and diff checks pass. Committed Rust/workflow changes exactly match the tested candidate. Hosted Tests run 34552411807 passes all 22 jobs, including the Windows shared library stage (489 passed, one ignored), the real native build and all 20 example links. Hosted Windows goldens skip the CPU adapter; their nominal 93 "ok" results are not physical-image qualification. Local Radeon and hosted Metal checks provide the physical rendering evidence. Named full-hardware quality jobs remain skipped.
The expanded physical Radeon FXC run fails four layered-material goldens during pipeline compilation: implicit LUT derivatives make FXC attempt to unroll varying light loops (X3570/X3511). The shader and failing test definitions are byte-identical to #163; those failures are retained and a separate explicit-LOD correction is being tested. This PR does not claim full physical FXC qualification. See the diagnostic report.
Stacked on #163; advances #140. This is a software-renderer CI workaround, and the underlying WARP/DXIL access violation remains open. Physical DX12/DXC and wider platform/hardware acceptance remain separate requirements. #163's published camera-history evidence retains the original hosted failure.
Published report and evidence retain the WARP/DXIL crashes, debugger stack, FXC controls, separate physical-FXC failures and exact hosted/source receipts. ZIP SHA-256:
0c181559edb073296bd74367c865f457b067bdfafc0436dbda48c25b32adf407.