Fix starter callback and color failures with full browser acceptance - #173
Draft
proggeramlug wants to merge 3 commits into
Draft
Fix starter callback and color failures with full browser acceptance#173proggeramlug wants to merge 3 commits into
proggeramlug wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated starter compiled for web but failed at runtime: named void callbacks reached Perry's i64 decoder as JavaScript
undefined, and imported palette colors reached FFI with undefined RGBA channels. Preserve actual void returns in the production bootstrap while retaining the existing boxed-value decoder and its errors. Give the starter explicit typed black/white literals.Require complete installed-starter browser acceptance. Windows creates the project through the installed CLI, runs unchanged source with
bloom run --web, checks exact served bytes/MIME and retains the entire website with hashes. The scoped upload includes hidden files. Hosted Chrome loads that exact output through the production bootstrap and checks real asset fetch/read, clear/text/square arguments, eight frames, normal stop, one completed cleanup and the expected 800x450 image.Validation:
Published report and evidence contain raw results, source receipts, captures, earlier failures and the exact patch. ZIP SHA-256:
5a8e79c4373fc5f16950bd9204f9078fdfcd902814378a001b6cd20d99cd0caa.General imported constant compatibility, canonical example browser/gameplay coverage, wider API/compiler qualification, browser physics, pause/focus, resize/device-loss handling and clean Windows distribution remain separate. Shared constant/example corrections are being qualified in #174. No PR merge or npm release is included.
Stacked on #172; relates to #142 and #74.