Fix portable example runtime and gate native/browser execution - #174
Draft
proggeramlug wants to merge 4 commits into
Draft
Fix portable example runtime and gate native/browser execution#174proggeramlug wants to merge 4 commits into
proggeramlug wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several canonical examples compiled but failed during execution: native scalar arithmetic truncated fractional interpolation/easing, voxel indexing lost captured dimensions, camera/derived-coordinate writes hid game content, and WASM barrel re-exports left public color and input constants undefined. Move six games onto the shared loop with explicit cleanup, correct those runtime paths, and require real native/browser startup content checks.
Keep scalar calculations in floating point without changing their formulas. Pass voxel dimensions explicitly and materialize camera/derived coordinates at their use sites. Preserve public palette, keyboard/mouse, cursor/platform, texture and material constants through initialized exports, retaining existing values, types and shared object identity through both public entry points.
Keep linked compiler test projects on the checkout's drive: hosted projects on
C:linked to the engine onD:caused Perry to emit colliding module globals that MSVC silently merged. Reject those linker warnings even when compilation exits successfully. Handle synchronous and asynchronous browser pointer-lock denial, retain the intent for a later click, and release a grant arriving after cursor cleanup.Add actual native/WASM scalar and public-constant contracts, including invalid-value controls, alias mutation/restoration and an executed FFI guard control. The native gate runs bounded copies of unchanged update/draw and cleanup bodies, requires completed readback and one cleanup, and checks specific game content outside the HUD. The browser gate compiles unchanged original sources, verifies source/page receipts, loads the production engine/bootstrap in hosted Chrome and requires eight drawing frames, valid draw/input arguments, the expected content and one completed cleanup. Space-blaster must close audio; voxel-sandbox must restore cursor intent. Browser evidence can still run after a later native failure; both jobs remain required.
Validation:
da31009passes actual browser content/cleanup for five games. Voxel Sandbox stops on an unhandled pointer-lock rejection, and the native constant fixture exposes the same cross-drive module collisions. Its failed binary also fails when replayed locally. These failures are retained; the drive-location and pointer-lock corrections await hosted verification.Startup checks do not qualify full gameplay/input interaction, pause/focus, resize/device loss, quality goldens or performance. The missing test3d grid lines, wider compiler/API export audit, visible Windows presentation, packaged shader dependencies and named discrete-hardware acceptance remain open.
Stacked on #173; relates to #142, #74 and #141. See
docs/evidence/example-loops-v1.mdanddocs/evidence/example-browser-v1.mdfor source receipts, failures and scope. No PR merge or npm release is included.