Conversation
…t imports Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
40 tasks
This was referenced Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for [Payment due abdulrahuman5196] Improve column auto-mapping when the file structure is different.
That PR changed how the company card spreadsheet import pre-selects field mappings. It now computes the whole mapping in one coordinated pass — matching the uploaded file's column headers to fields first, then falling back to the column positions saved from the previous upload only for fields the headers didn't resolve. A field can no longer be pre-selected on more than one column, and re-importing a differently structured file no longer produces nonsensical mappings such as a date landing on the amount column.
Import Company Card Transactions From a Spreadsheet described the old behavior only as "previously mapped fields auto-fill," which no longer explains what admins see. This PR updates that article:
## How Expensify fills in company card field mappingssection documenting the header-first order, the saved-position fallback, columns left as Ignore, and the limits (needs a header row, Unique ID is never auto-filled, matching is a best guess worth reviewing).internalScopenow names the auto-fill behavior.Accuracy notes — every behavioral claim was checked against the merged code in
src/libs/importSpreadsheetUtils.ts:243-290:findColumnNamehas no case that returnsEXTERNAL_ID, and the saved-mapping fallback skips it explicitly, so the article's existing Unique ID guidance stays correct.containsHeader, so the article says matching "only helps when your file has a header row" instead of tying it to that toggle.Transaction Date→ Date (remapped toPOSTED_DATE, the company card role labeled "Date"),Vendor→ Merchant,Posted Amount→ Amount.Label verification:
Company cardsandAdd cardswere confirmed against dev NewDot web. The remaining labels — Import transactions from file, Import spreadsheet, Card number, Card name, Date, Merchant, Amount, Currency, Unique ID, Ignore, and Import — were confirmed againstsrc/languages/en.ts, because the live Add cards flow is gated behind an account-validation magic code that the test session could not clear.No other help site article needs updating:
shouldAutoDetectColumns={false}is set only onCompanyCardsImportedPage, so the member, category, tag, per diem, merchant rules, and personal card import flows are unchanged.Fixed Issues
$
PROPOSAL:
There is no public App issue for this docs follow-up. The change it documents landed in [Payment due abdulrahuman5196] Improve column auto-mapping when the file structure is different, whose own linked issue is internal, so it isn't referenced here. Please add a linked issue if one is needed.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR only changes a markdown file under
docs/articles, so there is no app behavior to test. Reviewing the rendered article and confirming it matches current behavior is the relevant check.Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
Docs-only change — no QA needed on the app itself.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Gonals, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.