Repository navigation
Upgrade React Router with route and history compatibility gates - #198
Conversation
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Reviewed head is now On Fresh-cache production audit on this Router-only branch now has3 moderate UUID/federation entries,0 high/critical, and no Router/CSS entries. UUID is separately fixed in #196. Final exact-head CI and live-base integration checks remain pending; no deployment claim. |
…ity-20261027 # Conflicts: # .agents/issues/INDEX.md
|
Composed the independently reviewed editor focus correction #201 and live dev UUID merge into this branch. Frozen head Integration order is #201 → #198 → #199, with each retargeted to live dev only after its predecessor is verified. Actual base/tree composition will be rechecked before any merge. Old runs are retained as historical evidence, not substituted for these final gates. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Independent exact-head review cleared The previous six-case desktop/phone Router acceptance result remains scoped evidence. Final composed CI 40584829418 and Comprehensive 40584829408 are pending; older superseded CI is not a pass. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Current frozen head: Earlier CI Required browser collection is unchanged at 51 cases, now split into new-user (42), semantic-lod (2), and router-navigation (7), with the same deadlines, one worker, zero retries, and failure-only traces. This follows the separate CSS run Final local named sequences passed: router-navigation 7/7 in 101.0s, semantic-lod 2/2 in 262.8s. Harness 174/174 passed; reviewer separately passed 28 CLI/dependency checks and all three authentication controls. Current-head CI is still required before integration. Base is now dev after focus PR #201. |
|
Integration preflight: frozen reviewed head Final CI 40589115761 and Comprehensive 40589115727 passed all applicable jobs. Actual browser counts: 6 smoke, 42 new-user (704.6s), 2 semantic LOD (164.6s), 7 route compatibility (64.3s), 27 mobile, 3 effects, 3 performance; no required skips/flaky cases. Required DB contract and supported-Node unit/config checks passed. Earlier viewer-fixture failures and separate suite-budget failure are retained in the PR history with their corrections. Proceeding with the standing dev-only administrative integration authorization. Agent review is not GitHub non-author approval. Main and protection remain unchanged; resulting parents/tree and post-merge checks will be verified before closeout. |
|
Native administrative merge completed into dev. Verified remote merge Post-merge CI 40593468491 and Comprehensive 40593468455 are pending; integration closeout remains open until their actual results are inspected. Next stacked PR #204 is retargeted to dev; it will not overtake the required post-merge evidence. |
|
Post-merge verification is complete for dev Post-merge CI and Comprehensive passed. Actual browser results: smoke6, new-user42, LOD2, routes7, mobile27, effects3, performance3, all with no required skips or retries. Unit/build/type/lint/real-Neo4j and supported-Node/installer jobs passed. This was the owner-authorized native admin merge into dev; independent agent review was not represented as a GitHub non-author approval. No main, release, protection or deployment mutation occurred. The separately exposed LOD transition defect is tracked in #205 / #207; this green run does not erase that retained failure or claim it is fixed in dev yet. #186 remains open for the reviewed CSS follow-up. |
React Router6.30.6 remains in the advisory ranges for mixed-separator navigation and SSR error hydration. Upgrade the installed Router/DOM pair to7.18.4 while retaining GraphDone’s declarative BrowserRouter, existing imports and route structure. Related to #186; UUID/federation remains in #196 and CSS evidence is separate.
The lock removes the old
@remix-run/routerpath and contains only Router/DOM7.18.4. Official fixed ranges and the versioned v6 migration guide were checked; the selected release supports React18 and the supported Node22/24 runtimes. Source inspection found no application-controlled external destination or SSR hydration sink; this PR does not claim a demonstrated live exploit.Validation adds a guard for every locked Router path, actual installed-consumer navigation/history controls, and six required desktop/phone browser cases for public/authenticated deep links, reload, lazy navigation, history, role rejection and a fresh-context login callback. The callback uses an owned password-issued token, not a live OAuth provider.
The final mixed-separator control fails four cases on the original locked6.30.6 and passes all five cases on7.18.4; existing role guards bring the focused result to9/9. Earlier tests expected normalization from an older upstream test, but installed7.18.4 rejects these external-looking paths; that mistaken expectation and correction are retained. The first browser run passed both viewer/callback journeys and failed four cases because the test assumed Password and Admin Users were default tabs. Corrected steps select those actual controls explicitly; assertions and retry policy remain strict.
Frozen head
3e5a761dc0b067ed3827dd29fca50d45fb5d3952: independent review, corrected six-case browser run, full web suite, harness, fresh audit and exact-head CI are pending. Clean install and all builds/types/lint passed on the identical runtime/dependency tree before final test/document corrections. Draft until final gates and live-dev composition review pass. No deployment, shared library, audit-threshold relaxation or forced unrelated upgrade.Dated evidence:
.agents/inbox/2026-10-27-router-upgrades-need-current-consumer-contracts.md; inventory:docs/quality/SECURITY_SCOPE_2026-10-23.md.