Skip to content

Prevent detached Git maintenance from racing disposable fixture cleanup - #204

Merged
mvalancy merged 1 commit into
devfrom
fix/fixture-git-maintenance-20261027
Oct 27, 2026
Merged

mvalancy merged 1 commit into
devfrom
fix/fixture-git-maintenance-20261027

Conversation

@mvalancy

Copy link
Copy Markdown
Member

A disposable Git fixture can finish its synchronous commit while newer Git continues detached maintenance; immediate strict removal can race those writes. Configure automatic maintenance off only in the fixture repository before its first commit and verify the actual commit trace contains no maintenance child launch.

Fixes #203. This is stacked on Router #198 and must integrate before the downstream auth branches complete. No application runtime or global Git settings change.

Validation: the new real-process control fails old setup; corrected CLI 28/28 on Git 2.43 and CI-matching Git 2.55; pinned clean install and harness 175/175. Strict cleanup and failure propagation remain unchanged. Independent exact-head review and final CI pending.

Retained failure: OAuth Comprehensive 40589229879 reported ENOTEMPTY in two teardown hooks. Independent Git 2.55 probing found 12/12 detached maintenance launches and descendant activity after parent exit in 10/12 traces; fixture-local suppression eliminated launches in 12/12. The exact ENOTEMPTY was not reproduced locally, so identifying maintenance as that CI writer is an evidence-backed inference.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

Integration preflight: exact reviewed source 7fe08c5c92a2a00c6f13d5e7a7d3c2654fd302d5; live dev 752efaee49303fa6310f3e4edd4785ffad1331fc. Router post-merge CI and Comprehensive have passed. Dev's complete tree equals the reviewed Router source; git merge-tree --write-tree origin/dev HEAD yields 2256332a250c534b2bcd322c1c027acfb71c2688, identical to this source tree.

Final CI and Comprehensive passed. Actual application gates: smoke6, new-user42, LOD2, routes7, mobile27, effects3, performance3; no failed/skipped required cases. Supported Node22.18/24 and installer checks passed. Independent exact-head review found no remaining findings; local clean install and harness175/175, Git2.43/2.55 CLI28/28 and retained negative maintenance trace are recorded above.

Proceeding with the standing dev-only admin integration, not claiming a non-author GitHub approval. Post-merge CI remains required before closing #203. No protection/main/release/deployment changes.

@mvalancy
mvalancy marked this pull request as ready for review October 27, 2026 22:44
@mvalancy
mvalancy merged commit 8419292 into dev Oct 27, 2026
16 checks passed
@mvalancy

Copy link
Copy Markdown
Member Author

Native admin merge completed into dev 8419292ff4c6d015262ec3b319407863de1057d2. Verified parents are prior dev 752efaee49303fa6310f3e4edd4785ffad1331fc and reviewed source 7fe08c5c92a2a00c6f13d5e7a7d3c2654fd302d5; complete tree 2256332a250c534b2bcd322c1c027acfb71c2688 matches the reviewed source. Post-merge CI on this dev SHA is now required before closing #203. No main/release/deploy/protection mutation occurred.

@mvalancy

Copy link
Copy Markdown
Member Author

Post-merge CI40597120363 failed the phone semantic-LOD target assertion: expected1.2, received1.1582958391271292. This is the same overview-exit interruption already reproduced and corrected in reviewed #207 / #205; the maintenance source predates that correction. No fixture-lifetime regression is shown by this failure. Earlier final-head CI remains historical evidence, not a post-merge pass.

#203 stays open. The next integration is the independently reviewed correction #207 after its exact-head CI passes; successful post-merge CI on the corrected dev composition is required for closeout. The failed run/artifacts are retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant