Skip to content

Wait for completed camera resize before sampling idle motion - #210

Merged
mvalancy merged 2 commits into
devfrom
test/motion-camera-readiness-20261027
Oct 27, 2026
Merged

mvalancy merged 2 commits into
devfrom
test/motion-camera-readiness-20261027

Conversation

@mvalancy

Copy link
Copy Markdown
Member

The phone idle-motion test began sampling before a queued viewport resize and preceding edit had completed. CI 40597251568 recorded one common camera jump followed by 1,019 stable frames; source positions did not move.

The renderer exposes camera viewport/resize/transition readiness separately from physics rest. The test observes the persisted edit and rendered badge, deliberately delays real ResizeObserver delivery to prove the distinction, then retains the full 17-second sample and one-pixel limits.

Fixes #208. Stacked on LOD PR #207. Exact source 7cbf292f95869980a1784017b0786293c269f7e6 includes its corrected title selector and regression.

Validation:

  • New contract fails on the old runtime because camera readiness is absent; this is not represented as a local reproduction of the original CI jump.
  • Before the three-path LOD follow-up composition, all three motion viewports passed in 2.0 minutes with zero retries; build, typecheck, lint and harness 175/175 passed. Composition checks and final CI are pending.
  • Independent review, final exact-head CI and post-merge CI are required. No thresholds, test deadlines or retry budgets were widened.

Camera readiness describes the current viewport and active resize/transition, not all possible future timers. Evidence, cause and limits are recorded in the incident lesson and symptom index. All graph fixtures are owned and strictly cleaned up.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

The exact reviewed composition 7cbf292f95869980a1784017b0786293c269f7e6 now passes local motion 3/3 (2.1 minutes) and semantic LOD 2/2 (3.8 minutes), each one worker and zero retries. Full exact-head CI remains running. Independent review found no remaining findings; no motion thresholds/deadlines/retry budgets changed. Prior missing-readiness and wrong-selector failures remain retained. Post-merge CI is still required before closeout.

@mvalancy
mvalancy changed the base branch from fix/lod-transition-ownership-20261027 to dev October 27, 2026 23:56
@mvalancy
mvalancy marked this pull request as ready for review October 27, 2026 23:57
@mvalancy

Copy link
Copy Markdown
Member Author

Final dev integration preflight: source 7cbf292f95869980a1784017b0786293c269f7e6; live dev 088827939cd93853c4aa5af82ae41b99df7c19a8. The live base tree is exactly reviewed LOD source b12d083 (be00a67a1cdc13a9af50d33c5cc94835297eb1af); retargeting from that source branch to dev changes no reviewed feature content. Expected complete result tree: e5245391865b2f2f88333f47a6344d45d661bdc5.

Final CI and Comprehensive suite succeeded at the exact head. Every applicable job passed; main/nightly production is explicitly inapplicable. Actual strict artifacts verify smoke6, new-user42, LOD2, routes7, mobile27 and performance3 with zero failed/warned/skipped cases, execution errors or timeouts. Living-effects and showcase steps also passed. Local combined motion3/3 and LOD2/2 plus independent exact-head review remain retained.

This is native integration under standing dev-only admin authority, not a GitHub non-author approval. Earlier dev validation is still running; #203/#205/#208 remain open until the integrated dev head passes post-merge validation. No release, main, deployment or protection changes are included.

@mvalancy
mvalancy merged commit 6136731 into dev Oct 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant