Skip to content

Add optional illustrative looks for seven planets - #115

Draft
Protonmatter wants to merge 4 commits into
masterfrom
codex/planet-look-presets
Draft

Protonmatter wants to merge 4 commits into
masterfrom
codex/planet-look-presets

Conversation

@Protonmatter

Copy link
Copy Markdown
Owner

Outcome

Adds the Planet Look Lab maps to SOL for Mercury, Venus, Mars, Jupiter, Saturn, Uranus and Neptune through Solar System → View → Planet appearance → Illustrative look. Source-qualified remains the default. Earth, Sun and moons keep their existing SOL materials.

This is a draft candidate, not a production release. The independent lab fixes—darker Earth oceans and surface-anchored, evolving Sun arches—are already published at https://sol-planet-look-lab.protonmatter.chatgpt.site.

Specification and traceability

  • Requirement: SOL-VIS-008.
  • Draft RFC: docs/rfcs/0007-illustrative-planet-looks.md.
  • Specification/plan: docs/SPEC.md and docs/superpowers/plans/2026-09-23-illustrative-planet-looks.md.
  • No orbital, snapshot, geographic-registration or scientific-admission changes; no runtime dependencies.
  • RFC remains Draft pending owner design review. Existing CI and release qualification are retained.

Behavior and risk

  • Seven original 2K maps, attributed to Solar System Scope / INOVE (CC BY 4.0), with pinned byte counts, SHA-256 and dimensions.
  • Explicit artistic-color/reconstructed-coverage disclosure; loading and failure states never claim observed imagery.
  • Separate two-map cache, loading only useful visible bodies. Unwanted loads are aborted; stale decodes close their bitmap; context loss releases resources.
  • Existing physical positions, rotation, ellipsoids, illumination and rings are reused.
  • Measured Mars terrain is suspended while its unregistered artistic map is shown. Venus radar takes precedence over the cloud look.
  • Disabling textures or returning to Source-qualified restores existing behavior.
  • Same-origin assets; no personal data, external runtime fetches or new permissions.

UI and UX

A labelled native selector with associated explanatory text and source/license links. Existing controls, focus handling and texture checkbox remain in use. No new animation. The lab appearance has been inspected in the desktop software renderer; this does not qualify SOL's GPU integration or physical mobile behavior.

Validation evidence

  • npm test: 1,318 passed (baseline 1,310 passed).
  • New tests cover mode/default/eligibility, demand limits, asset identity, corrupt inputs, aborts, preserved physical snapshots, source restoration, failure retries and context loss.
  • python tools/typecheck_web.py: 114 files pass.
  • SDLC, documentation, UX and static web validators: pass.
  • Ephemeris service suite: 28 passed.
  • Python discovery: 388 tests run; 5 errors caused by missing cargo/rustc; 3 skipped. This is not a green full-suite result.
  • Rust/WASM, actual GPU/browser visuals, coverage and physical mobile checks remain required CI/manual work; no production build or deployment is claimed.

Independent code review found no Critical or Important runtime issues. One deferred minor: make the context-loss test assert deletion of the specific illustrative texture handles, rather than an aggregate count that includes other resources. Cleanup is implemented, but that regression assertion can be stronger.

Documentation and rollback

README, SPEC, requirement traceability, RFC and implementation/validation notes are updated. Switch to Source-qualified for immediate visual rollback, or revert this commit for full removal. No data migration. Do not merge until RFC review and required CI/rendering gates are satisfied.

Add attributed Solar System Scope materials behind a source-qualified-default selector, preserve physical state, and bound/cancel resource loads. RFC 0007 remains Draft pending design review and required rendering/CI gates.
Default Venus keeps its Magellan citation, artistic maps decode before lighting on both sphere programs, and the lifecycle tests lock texture identity, terrain, and context loss.
Keep the artistic cloud map when radar is on and composite it as a translucent shell instead of replacing the registered surface.
The lifecycle test loads the registered mosaic and checks the ground pass uses it while the artistic map stays on the shell.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant