Add optional illustrative looks for seven planets - #115
Draft
Protonmatter wants to merge 4 commits into
Draft
Protonmatter wants to merge 4 commits into
Protonmatter wants to merge 4 commits into
Conversation
Add attributed Solar System Scope materials behind a source-qualified-default selector, preserve physical state, and bound/cancel resource loads. RFC 0007 remains Draft pending design review and required rendering/CI gates.
10 tasks
Default Venus keeps its Magellan citation, artistic maps decode before lighting on both sphere programs, and the lifecycle tests lock texture identity, terrain, and context loss.
7 tasks
Keep the artistic cloud map when radar is on and composite it as a translucent shell instead of replacing the registered surface.
The lifecycle test loads the registered mosaic and checks the ground pass uses it while the artistic map stays on the shell.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Adds the Planet Look Lab maps to SOL for Mercury, Venus, Mars, Jupiter, Saturn, Uranus and Neptune through Solar System → View → Planet appearance → Illustrative look. Source-qualified remains the default. Earth, Sun and moons keep their existing SOL materials.
This is a draft candidate, not a production release. The independent lab fixes—darker Earth oceans and surface-anchored, evolving Sun arches—are already published at https://sol-planet-look-lab.protonmatter.chatgpt.site.
Specification and traceability
docs/rfcs/0007-illustrative-planet-looks.md.docs/SPEC.mdanddocs/superpowers/plans/2026-09-23-illustrative-planet-looks.md.Behavior and risk
UI and UX
A labelled native selector with associated explanatory text and source/license links. Existing controls, focus handling and texture checkbox remain in use. No new animation. The lab appearance has been inspected in the desktop software renderer; this does not qualify SOL's GPU integration or physical mobile behavior.
Validation evidence
npm test: 1,318 passed (baseline 1,310 passed).python tools/typecheck_web.py: 114 files pass.Independent code review found no Critical or Important runtime issues. One deferred minor: make the context-loss test assert deletion of the specific illustrative texture handles, rather than an aggregate count that includes other resources. Cleanup is implemented, but that regression assertion can be stronger.
Documentation and rollback
README, SPEC, requirement traceability, RFC and implementation/validation notes are updated. Switch to Source-qualified for immediate visual rollback, or revert this commit for full removal. No data migration. Do not merge until RFC review and required CI/rendering gates are satisfied.