Repository navigation
feat(users): add /user/ssh_keys CRUD API - #1444
Merged
olevski merged 2 commits intoSep 30, 2026
Merged
Conversation
SalimKayal
added this pull request to stack #1445
September 14, 2026 12:33
Coverage Report for CI Build 36726908623Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 85.296%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
from
September 14, 2026 17:40
ed11d45 to
f219ad7
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 14, 2026 17:40
142ede6 to
c0bafb8
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 17, 2026 14:44
c0bafb8 to
3ca9626
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
from
September 17, 2026 14:44
f219ad7 to
2b6cc40
Compare
This was referenced Sep 18, 2026
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
from
September 18, 2026 09:46
2b6cc40 to
d6ccc38
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
2 times, most recently
from
September 24, 2026 09:02
d16645f to
f434366
Compare
This was referenced Sep 24, 2026
eikek
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 25, 2026 08:37
f434366 to
a083c50
Compare
eikek
previously approved these changes
Sep 25, 2026
olevski
previously approved these changes
Sep 25, 2026
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 29, 2026 13:20
a083c50 to
f78aa4b
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
from
September 29, 2026 13:20
6f6f529 to
5250199
Compare
SalimKayal
removed this pull request from stack #1445
September 29, 2026 14:59
SalimKayal
added this pull request to stack #1465
September 29, 2026 15:05
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 29, 2026 16:49
f78aa4b to
9379d90
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
from
September 29, 2026 17:46
2475761 to
5fa4a5d
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 29, 2026 17:46
9379d90 to
02d9e65
Compare
olevski
force-pushed
the
salimkayal/feat/ssh-keys_store
branch
2 times, most recently
from
September 30, 2026 13:17
ef09457 to
de66e6c
Compare
olevski
removed this pull request from stack #1465
September 30, 2026 13:50
Base automatically changed from
salimkayal/feat/ssh-keys_store
to
salimkayal/feat/ssh-keys
September 30, 2026 13:52
olevski
force-pushed
the
salimkayal/feat/ssh-keys
branch
from
September 30, 2026 13:57
92eca04 to
e04664f
Compare
olevski
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 30, 2026 14:01
02d9e65 to
66291c1
Compare
olevski
force-pushed
the
salimkayal/feat/ssh-keys_user-api
branch
from
September 30, 2026 14:02
66291c1 to
e8e2a0b
Compare
olevski
marked this pull request as ready for review
September 30, 2026 14:03
olevski
approved these changes
Sep 30, 2026
olevski
pushed a commit
that referenced
this pull request
Oct 2, 2026
olevski
added a commit
that referenced
this pull request
Oct 13, 2026
* feat(users): store ssh keys (#1442) * feat(users): add /user/ssh_keys CRUD API (#1444) * feat: proxy api for ssh keys (#1446) * feat(notebooks): configure proxy-to-session key secret names (#1452) * feat: Add frontend variant as session label (#1455) * feat(notebooks): mount proxy-to-session keys only for ssh frontends (#1458) * feat: return ssh url for sessions with ssh frontend (#1467) Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com> Co-authored-by: boucherjeanphi <49230173+boucherjeanphi@users.noreply.github.com> Co-authored-by: eikek <701128+eikek@users.noreply.github.com> Co-authored-by: Eike Kettner <eike.kettner@sdsc.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the SSH public key store over the data-services API:
GET/POST /user/ssh_keysandGET/DELETE /user/ssh_keys/{key_id}. Users can register, list, and revoke their own keys. Second PR of the three-PR SSH stack; the internal proxy endpoints follow in #1446 .Motivation and context
#1442 added the storage foundation but nothing could reach it. This PR is the user-facing surface that lets a user manage the keys the SSH gateway will authenticate them with. Keys belong to the authenticated user, so every route is owner-scoped at the SQL level.
Behavior
GET /user/ssh_keyslists the caller's keys;POST /user/ssh_keysregisters one (201).GET /user/ssh_keys/{key_id}returns one key;DELETE /user/ssh_keys/{key_id}removes it (204, idempotent).public_keyis canonicalized (comment stripped) and fingerprinted asssh-keygen -lreports, so the stored fingerprint is display-ready.Changes
components/renku_data_services/users/api.spec.yaml: new/user/ssh_keysand/user/ssh_keys/{key_id}paths;SSHKey,SSHKeyPost(withmaxLength: 256onname),SSHKeysListschemas.components/renku_data_services/users/apispec.py: regenerated with the pinneddatamodel-code-generator 0.57.0(see Notes).components/renku_data_services/users/blueprints.py:SSHKeysBP, modeled onUserSecretsBP, delegating toSSHKeyRepositoryandvalidate_unsaved_ssh_key.bases/renku_data_services/data_api/{app.py,dependencies.py}: construct and wireSSHKeyRepository; register the blueprint.test/utils.py:TestDependencyManagerpasses the newssh_key_repofield.test/bases/renku_data_services/data_api/test_ssh_keys.py: CRUD, 409 duplicate, 404/204 missing id, 422 malformed and overlong name, 401 unauthenticated, cross-user scoping.Notes
PR Stack