Repository navigation
feat: ssh proxy service account authn - #1448
Closed
SalimKayal wants to merge 14 commits into
Closed
SalimKayal wants to merge 14 commits into
SalimKayal wants to merge 14 commits into
Conversation
SalimKayal
changed the base branch from
main
to
salimkayal/feat/ssh-keys_proxy-api
September 17, 2026 14:28
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_proxy-api
branch
from
September 17, 2026 14:44
87caf4f to
5e87f9f
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-proxy-service-account-authn
branch
from
September 17, 2026 14:44
df9a178 to
5375ea2
Compare
This was referenced Sep 18, 2026
SalimKayal
force-pushed
the
salimkayal/feat/ssh-proxy-service-account-authn
branch
from
September 18, 2026 09:46
5375ea2 to
fd0eb53
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_proxy-api
branch
from
September 18, 2026 09:46
5e87f9f to
a1831be
Compare
Coverage Report for CI Build 35978868057Warning No base build found for commit Coverage: 85.455%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
SalimKayal
force-pushed
the
salimkayal/feat/ssh-proxy-service-account-authn
branch
from
September 24, 2026 09:02
fd0eb53 to
450e78e
Compare
This was referenced Sep 24, 2026
* fix: wrong url for secret service in data exports This was breaking exporting data from Renku when the data connector that we are exporting from has a saved secret. * fix: fix error with owner reference in _request_saved_secret_creation --------- Co-authored-by: Jean-Philippe Boucher <jean-philippe.boucher@epfl.ch>
eikek
force-pushed
the
salimkayal/feat/ssh-proxy-service-account-authn
branch
from
September 25, 2026 08:37
450e78e to
622144b
Compare
eikek
previously approved these changes
Sep 25, 2026
SalimKayal
dismissed
eikek’s stale review
September 29, 2026 13:20
The merge-base changed after approval.
SalimKayal
force-pushed
the
salimkayal/feat/ssh-keys_proxy-api
branch
from
September 29, 2026 13:20
a5fd7d3 to
1ef456d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The internal proxy endpoint
POST /internal/sessions/{session_id}/authorizenow requires a Keycloak service-account token carrying thessh-proxyrealm role; it was unauthenticated (POC). Plan 3 ofservice-account-plan.md.Motivation and context
The proxy is the internet-facing first hop. #1446 left the endpoint public so the flow could be exercised; this puts authentication back using a realm role created Keycloak.
Behavior
401; valid user token without the role →403;ssh-proxyrole → existing204/404logic.renku-admin(is_admin) bypasses the role check.Changes
ssh_proxy/blueprints.py,data_api/app.py: addauthenticator+ssh_proxy_role="ssh-proxy"toSSHProxyBP, gate the handler with@authenticate+@require_role, wiredm.authenticator.ssh_proxy/api.spec.yaml: add401/403responses.test/.../test_ssh_proxy.py: auth-matrix tests (no token / user / wrong role / admin bypass / service account).users/core.py: docstring now says "authorize endpoint" (incidental, unrelated).Notes
ssh-proxyclient a token withrealm_access.roles: ["ssh-proxy"]and anaudin["renku","renku-ui","renku-cli","swagger"]; a missing audience fails closed to 401.PR Stack