Repository navigation
chore(coverage): give the bundle e2e coverage run a regression floor (99/95/98/99) instead of zeroed thresholds - #484
Merged
Conversation
…99) instead of zeroed thresholds vitest.e2e-coverage.config.mjs pinned every threshold to 0, so a bundle scenario that stopped driving a src/ path lowered the e2e figure without failing anything. Set the floor just under main@d93ecb8 (99.54 lines / 96.25 branches / 98.79 functions / 99.56 statements) and note it in docs/contributing.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
|
Please add a kind label with |
2 tasks
9 of 12 tasks
mrbobbytables
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage Configuration
Files claimed:
vitest.e2e-coverage.config.mjs(coverage.thresholds),docs/contributing.md(thetest:coverage:e2erow). No held PR (#467–#483) touches either.vitest.e2e-coverage.config.mjspinned all four thresholds to0, so a bundle scenario that stopped driving asrc/path lowered the end-to-end figure without failing anything, locally or (once #459's job lands) in CI. This sets a floor just under whatmainreaches:Verified on this branch:
npm run test:coverage:e2epasses (461 tests, exit 0); running the same config with--exclude '__tests__/bundle/tide*.test.ts'fails withCoverage for lines (98.91%) does not meet global threshold (99%)/statements (98.96%).npm run lintpasses. The held bundle PRs #467–#483 only add scenarios, so none would trip the floor (with all of them merged the figure is 99.91 / 97.46 / 100 / 99.92).For the reviewer: #459's body proposed the
e2e-coveragejob as "a record, not a gate" with no threshold. This PR makes the run a gate instead — a local or CI run now fails on a regression. If you prefer the record-only framing, close this and the job in #459 stays green regardless of the figure; the numbers above are the evidence either way. A laterncc/vitestbump that shifts source-map attribution could move the figure by a few lines; the ~0.5 % margin (13 lines) is the budget for that.Related Issue
Refs #459 (needs-human: the
e2e-coveragejob itself lives in.github/workflows/test.yml, which this lane's token cannot push — drop-in YAML is in the issue body; this PR is only the threshold half, folded into #459 as the[quality] missing-workflow: test.yml never runs npm run test:coverage:e2efinding)Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88