Conversation
Port PR #245 onto main, retaining diffr v3 folding, alignment, streaming counts, and configuration. Stream exact pinned trees through the JSON review API, support absent sides, and use the structural provider in Monaco while preserving the ordinary unified renderer. Agent-Session: 01a0abcb-f97f-7431-a8d0-9e7a2bb0d192 Agent-Session: 01a0ac29-e501-7282-941e-9d999e389f97 Agent-Session: 01a0ac09-05a3-70e3-8f9c-5c52947ccb2f Agent-Session: 01a0ac8d-66c7-77c2-bea1-b1bbba7cd7d8
Agent-Session: 01a0abcb-f97f-7431-a8d0-9e7a2bb0d192 Agent-Session: 01a0ac29-e501-7282-941e-9d999e389f97 Agent-Session: 01a0ac09-05a3-70e3-8f9c-5c52947ccb2f Agent-Session: 01a0ac8d-66c7-77c2-bea1-b1bbba7cd7d8
Agent-Session: 01a0ac29-e501-7282-941e-9d999e389f97 Agent-Session: 01a0b19a-2fda-72f0-9918-b540e7e4f1f9
sidkmenon
added this pull request to stack #371
September 19, 2026 02:12
sidkmenon
changed the title
Consume the final shared diffr DTO and schema at its rewritten immutable revision. Keep Source navigation separate from displayed evidence, represent range/result targets explicitly, and accept legacy saved payloads without manufacturing missing source trees. Package contracts precede their consumers. AI assistance: reorganized with Codex.
Use Source or SearchResultData in code peeks, sequence and stack frames, database operations and file lenses. Test shared sources, independent display, legacy reads and rejected payloads against the public contract. AI assistance: reorganized with Codex.
sidkmenon
force-pushed
the
codex/diffr-evidence-contract
branch
from
September 19, 2026 21:50
bb635df to
fb71000
Compare
sidkmenon
removed this pull request from stack #371
September 19, 2026 21:50
sidkmenon
added this pull request to stack #382
September 19, 2026 21:51
sidkmenon
changed the title
This was referenced Sep 19, 2026
An error occurred while trying to automatically change base from
codex/diagram-lenses
to
diffr-wire-v2
September 21, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept Source or SearchResultData through existing authoring contracts. Separate display targets from navigation coordinates, preserve complete comparisons with independent display, and retain compatibility for existing snapshots. Pin shared types/schema to the rewritten diffr commit.
Review order: #369 → #381 → #370. Builds on codex/diagram-lenses; consumes diffr #13.
Read commit by commit:
3e6b6bf81— Define portable code evidence and explicit display targets.fb710009c— Accept diffr evidence in existing authoring blocks.Verification: all application source blobs match the previously tested Review tip. Only dependency manifests/lockfile now pin the identical rewritten diffr tree. Fresh validation after repinning: frozen-lockfile install succeeded and all 107 focused source/API/local-data tests passed. Prior native validation: 20 presentation tests, typechecks and the dev build passed, and saved evidence was inspected in the running app. Review-order documentation was refreshed.
This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.
AI assistance: authored and reorganized with Codex.