Skip to content

Render authored evidence in the existing structural diff view - #370

Closed
sidkmenon wants to merge 3 commits into
codex/diffr-evidence-storagefrom
codex/diffr-evidence
Closed

sidkmenon wants to merge 3 commits into
codex/diffr-evidence-storagefrom
codex/diffr-evidence

Conversation

@sidkmenon

@sidkmenon sidkmenon commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Carry evidence through existing app surfaces and render its trees in the existing structural Monaco component. Honor one-sided display without manufacturing counterpart rows, show blue search highlights, and preserve folds and summaries. Presentation tests and the original live E2E record follow the implementation.

Review order: #369 → #381 → #370. Builds on codex/diagram-lenses; consumes diffr #13.

Read commit by commit:

  1. 306a07564 — Pass authored evidence through existing Review app surfaces.
  2. 53645ca62 — Render supplied trees with the existing structural Monaco diff view.
  3. 1c9455545 — Verify structural evidence rendering and record live E2E results.

Verification: all application source blobs match the previously tested Review tip. Only dependency manifests/lockfile now pin the identical rewritten diffr tree. Fresh validation after repinning: frozen-lockfile install succeeded and all 107 focused source/API/local-data tests passed. Prior native validation: 20 presentation tests, typechecks and the dev build passed, and saved evidence was inspected in the running app. Review-order documentation was refreshed.

This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.

AI assistance: authored and reorganized with Codex.

@sidkmenon
sidkmenon added this pull request to stack #371 September 19, 2026 02:12
@sidkmenon sidkmenon changed the title codex/diffr evidence Render and retain diffr search results in Review Sep 19, 2026
Update code peeks, inline editors, stack views, diagrams and diff sections to carry discriminated evidence content and targets through the existing protocol.

AI assistance: reorganized with Codex.
Honor display sides independently of complete retained comparisons. Use the existing structural renderer for folds and summaries, add blue search highlights, and retain one-sided full-width layout and navigation. No custom replacement diff component.

AI assistance: reorganized with Codex.
@sidkmenon
sidkmenon removed this pull request from stack #371 September 19, 2026 21:50
@sidkmenon
sidkmenon changed the base branch from codex/diffr-evidence-contract to codex/diffr-evidence-storage September 19, 2026 21:51
@sidkmenon
sidkmenon added this pull request to stack #382 September 19, 2026 21:51
@sidkmenon sidkmenon changed the title Render and retain diffr search results in Review Render authored evidence in the existing structural diff view Sep 19, 2026
Cover shared, paired and one-sided evidence, structural folds, navigation and lens propagation. Retain the prior live-dev-build verification record with its original tested commit identities; the history rewrite preserves all application code.

AI assistance: reorganized with Codex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants