Conversation
sidkmenon
added this pull request to stack #14
September 19, 2026 02:10
sidkmenon
changed the title
This was referenced Sep 19, 2026
Export native-independent runtime validation for the shared DTO. Check comparison shape, identities, paths, UTF-8 coordinates and region coverage. Document direct submission into Review existing APIs and snapshot JSON. AI assistance: reorganized with Codex.
Cover complete comparisons, independent display, shared sources and schema rejection. Add a live Review smoke flow with one-sided and paired lenses, mixed targets and diagram evidence using the same serialized results. AI assistance: reorganized with Codex.
sidkmenon
force-pushed
the
codex/review-evidence
branch
from
September 19, 2026 21:49
9516f12 to
f9419f4
Compare
sidkmenon
removed this pull request from stack #14
September 19, 2026 21:50
sidkmenon
changed the base branch from
codex/review-evidence-contract
to
codex/jev-search
September 19, 2026 21:50
sidkmenon
added this pull request to stack #21
September 19, 2026 21:50
This was referenced Sep 19, 2026
sidkmenon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose shared runtime validation alongside the method-free DTO. Exercise complete/shared comparisons, independent display and direct Review authoring through lenses and diagrams. Review persists the selected evidence inline; no upload resource or server-side search flow is added.
Review order: #6 → #7 → #20 → #8 → #10 → #13.
Read commit by commit:
d4a53a3db— Validate portable search evidence for Review consumers.f9419f48b— Exercise search contracts and direct Review submission.Verification: the complete rewritten diffr tip has exactly the same Git tree as the previously tested tip (262 Rust tests passed, one ignored; 11 JS tests passed; TypeScript checks and the real pretty-output contract passed). No behavior changes in this rewrite. Consumer stack: devdotfast/whiteboard#369 → devdotfast/whiteboard#381 → devdotfast/whiteboard#370.
This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.
AI assistance: authored and reorganized with Codex.