Repository navigation
Add strict typed Python surface and speed up bindings - #165
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a53716648b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| title: "Published release", | ||
| body: | ||
| "DotMatch v0.2.2 is available from PyPI and Bioconda. The package pages list the current release and installation files." |
There was a problem hiding this comment.
Report the actual 0.1.9 release on the homepage
The homepage tells users that v0.2.2 is available from PyPI and Bioconda, and repeats that version in the release trust fact, but this commit declares and documents 0.1.9 in pyproject.toml, package.json, and docs/distribution-release.json. Anyone following the package links will find a different release than advertised, so these claims should use the recorded 0.1.9 version.
Useful? React with 👍 / 👎.
| "", | ||
| f"DotMatch {PYTHON_PACKAGE_VERSION} was used for deterministic known-target short-DNA assignment.", | ||
| f"The assay mode was `{plan.spec.mode}` and the assay type was `{plan.spec.assay_type}`.", | ||
| "Reads were assigned only when exactly one known target was compatible under the configured policy; ambiguous reads were not silently counted.", |
There was a problem hiding this comment.
Describe best-policy assignments accurately
For an AssaySpec using ambiguity_policy = "best", the generated methods.md still says that reads were assigned only when exactly one target was compatible. Under the best policy, a read can be assigned uniquely when several targets lie within k as long as only one has the best distance, so this statement makes the generated methods and handoff artifacts misdescribe the actual selection rule. Generate policy-specific wording instead.
Useful? React with 👍 / 👎.
a537166 to
fa41d0b
Compare
Summary
Verification
Note: result records are now NamedTuples (field access and keyword construction unchanged; tuple-compatible equality).