Skip to content

Fix typed-release gates and tighten typed tests - #167

Merged
dnncha merged 1 commit into
mainfrom
fix-typed
Oct 27, 2026
Merged

dnncha merged 1 commit into
mainfrom
fix-typed

Conversation

@dnncha

@dnncha dnncha commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Follow-up to #165.

  • Keep release/pretag workflows runnable without dev-only mypy/pyright/ruff; make quality remains the typed gate.
  • Verify py.typed in --wheel-only published-wheel checks.
  • Convert FastqRecord to a NamedTuple so the changelog is accurate.
  • Make the benchmark command reproducible (31 repeats), re-measure against 91e162b, and record the merged commit.
  • Exercise the unique stream path and assert seqlev certificate distances.

Local gates: make typecheck, make lint, make examples-test, 2105 pytest passed, wheel and sdist checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T20:29:58.260861Z a44e7b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dnncha
dnncha merged commit de86d2d into main Oct 27, 2026
22 of 28 checks passed
@dnncha
dnncha deleted the fix-typed branch October 27, 2026 20:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a44e7b3bce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant