Skip to content

fix(javascript): reject malformed date strings - #3509

Open
schani wants to merge 1 commit into
agent/effect-date-time-validation-v2from
agent/javascript-prototype-map
Open

fix(javascript): reject malformed date strings#3509
schani wants to merge 1 commit into
agent/effect-date-time-validation-v2from
agent/javascript-prototype-map

Conversation

@schani

@schani schani commented Sep 7, 2026

Copy link
Copy Markdown
Member

JavaScript, TypeScript, Flow, and JavaScript PropTypes accepted malformed date-time values such as "1". Validate timestamp shape before conversion; PropTypes retains date-only support because it maps JSON Schema date to the same validator.

Introduces unchanged shared malformed case 8 after Zod, Effect, and Python support. Depends on #3518.

Production diff: 7 lines changed.

Validation: build; API unit test; combined date-time fixtures across Zod, Effect, Python, JavaScript, and PropTypes pass. Full affected JavaScript/TypeScript/Flow groups passed 506 tests; PropTypes passed 145.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1023 files differ — 1023 modified, 0 new, 0 deleted
7161 changed lines — +4092 / −3069

Open the generated-output report →

@schani
schani force-pushed the agent/javascript-prototype-map branch from 3683de3 to eb56530 Compare September 7, 2026 14:34
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1023 files differ — 1023 modified, 0 new, 0 deleted
5115 changed lines — +5115 / −0

Open the generated-output report →

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1023 files differ — 1023 modified, 0 new, 0 deleted
5115 changed lines — +5115 / −0

Open the generated-output report →

@schani
schani force-pushed the agent/javascript-prototype-map branch from 3287732 to 78b0921 Compare September 7, 2026 15:05
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1090 files differ — 1090 modified, 0 new, 0 deleted
5361 changed lines — +5238 / −123

Open the generated-output report →

@schani
schani force-pushed the agent/javascript-prototype-map branch from 78b0921 to a3a3db9 Compare September 7, 2026 15:08
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1090 files differ — 1090 modified, 0 new, 0 deleted
5361 changed lines — +5238 / −123

Open the generated-output report →

@schani
schani force-pushed the agent/zod-date-time-validation-v2 branch from 026db92 to 7876d0b Compare September 7, 2026 15:16
@schani
schani force-pushed the agent/javascript-prototype-map branch from a3a3db9 to 5e700f5 Compare September 7, 2026 15:17
@schani
schani force-pushed the agent/zod-date-time-validation-v2 branch from 7876d0b to a8cf6b3 Compare September 7, 2026 15:20
@schani
schani force-pushed the agent/javascript-prototype-map branch from 5e700f5 to 345ba7c Compare September 7, 2026 15:20
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1090 files differ — 1090 modified, 0 new, 0 deleted
5361 changed lines — +5238 / −123

Open the generated-output report →

@schani
schani force-pushed the agent/zod-date-time-validation-v2 branch from a8cf6b3 to 2399eed Compare September 7, 2026 15:25
@schani
schani force-pushed the agent/javascript-prototype-map branch from 345ba7c to d7cb7d8 Compare September 7, 2026 15:25
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1090 files differ — 1090 modified, 0 new, 0 deleted
5361 changed lines — +5238 / −123

Open the generated-output report →

@schani
schani force-pushed the agent/zod-date-time-validation-v2 branch from 2399eed to d328bcc Compare September 7, 2026 17:52
@schani
schani force-pushed the agent/javascript-prototype-map branch from d7cb7d8 to 7ec5b2c Compare September 7, 2026 17:55
@schani
schani changed the base branch from agent/zod-date-time-validation-v2 to fix/python-iso-date-time September 7, 2026 17:55
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1191 files differ — 1191 modified, 0 new, 0 deleted
5687 changed lines — +5401 / −286

Open the generated-output report →

@schani
schani force-pushed the fix/python-iso-date-time branch from 0a4bddc to fd3c42c Compare September 7, 2026 18:01
@schani
schani force-pushed the agent/javascript-prototype-map branch from 7ec5b2c to 3b2b8a4 Compare September 7, 2026 18:01
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Generated-output differences

1090 files differ — 1090 modified, 0 new, 0 deleted
5361 changed lines — +5238 / −123

Open the generated-output report →

Base automatically changed from fix/python-iso-date-time to agent/effect-date-time-validation-v2 September 8, 2026 01:46
@schani
schani force-pushed the agent/effect-date-time-validation-v2 branch from 2eeb64d to 94441d5 Compare September 8, 2026 02:45
@schani
schani force-pushed the agent/javascript-prototype-map branch from 3b2b8a4 to 9972111 Compare September 8, 2026 02:46
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Generated-output differences

1095 files differ — 1095 modified, 0 new, 0 deleted
5386 changed lines — +5263 / −123

Open the generated-output report →

@schani
schani force-pushed the agent/effect-date-time-validation-v2 branch from 94441d5 to 4ba516e Compare September 8, 2026 03:05
@schani
schani force-pushed the agent/javascript-prototype-map branch from 9972111 to 34dfa6b Compare September 8, 2026 03:05
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Generated-output differences

1095 files differ — 1095 modified, 0 new, 0 deleted
5386 changed lines — +5263 / −123

Open the generated-output report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant