chore(producer): shim __filename/__dirname in the CJS banner#1553
Open
miguel-heygen wants to merge 1 commit into
Open
chore(producer): shim __filename/__dirname in the CJS banner#1553miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Collaborator
Author
This was referenced Jun 18, 2026
Bundled CJS deps like wawoff2 call __dirname; without the shim they throw "__dirname is not defined in ES module" at render time. Also ignore .zed/.
miguel-heygen
force-pushed
the
chore/producer-esm-dirname-shim
branch
from
99da598 to
e5e8d40
Compare
jrusso1020
approved these changes
Jun 18, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Approved at e5e8d40c per Rames D Jusso + Via consolidated stack review. Tiny, mechanical CJS-banner shim for __filename / __dirname. No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: foundation of the GSAP keyframe + motion-path editing feature (#1553 → #1561).
What
Extend the producer's ESM-output build banner to define the CJS-only
__filename/__dirnameglobals (alongside the existingrequireshim), and gitignore local.zed/editor settings.Why
packages/produceris bundled to ESM, but several bundled CJS dependencies assume CommonJS globals.requirewas already shimmed;wawoff2(WOFF2 font subsetting) additionally reads__dirnameand throws__dirname is not defined in ES moduleat render time.How
Build the banner from
import.meta.url:createRequire(import.meta.url)→requirefileURLToPath(import.meta.url)→__filenamedirname(__filename)→__dirnameTest plan
bun run build(producer) succeeds