feat(studio): motion-path geometry + commit helpers#1559
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 18, 2026
miguel-heygen
force-pushed
the
feat/studio-motion-path-helpers
branch
from
8a34a71 to
c6c515d
Compare
miguel-heygen
force-pushed
the
feat/studio-gsap-drag-infra
branch
from
654d55e to
4c38428
Compare
jrusso1020
approved these changes
Jun 18, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Approved at c6c515d2 per Rames D Jusso stack review. Motion-path geometry + commit helpers — clean isolated addition.
Reminder: PR body is the unfilled template (stack-wide process flag); please fill in before merge.
miguel-heygen
force-pushed
the
feat/studio-gsap-drag-infra
branch
from
4c38428 to
a3a26a9
Compare
miguel-heygen
force-pushed
the
feat/studio-motion-path-helpers
branch
from
c6c515d to
87a7fd0
Compare
Pure path building, nearest-point projection, mutation-payload construction, selection + preview-visibility helpers. Fully unit-tested, no JSX.
miguel-heygen
force-pushed
the
feat/studio-motion-path-helpers
branch
from
87a7fd0 to
7bb643e
Compare
jrusso1020
approved these changes
Jun 18, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Re-approved at 7bb643ee post-restack. Motion-path geometry + commit helpers; clean isolated addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: GSAP keyframe + motion-path editing — overlay geometry helpers (#1553 → #1561).
What
Pure geometry + commit helpers for the motion-path overlay: build a polyline / arc path from a tween's keyframes, hit-test nodes, and map a node drag back to a source mutation. No React — keeps the overlay component thin and the math unit-testable.
Why
Coordinate math and commit mapping are the error-prone parts of the overlay; isolating them makes the overlay component small and lets the geometry be tested deterministically.
How
motionPathGeometry.ts: keyframes → points / segments (linear + motionPath arc).motionPathSelection.ts: resolve the editable tween for a selection.motionPathCommit.ts: map a node/waypoint drag to a keyframe / motion-path mutation.domEditOverlayGeometry.ts: shared overlay rect/selection-key helpers.Test plan
bun run test(studio) green