feat(studio): GSAP runtime read layer + shared helpers#1557
Open
miguel-heygen wants to merge 1 commit into
Open
feat(studio): GSAP runtime read layer + shared helpers#1557miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 18, 2026
miguel-heygen
force-pushed
the
feat/studio-gsap-read-layer
branch
from
3365d24 to
74c37f3
Compare
miguel-heygen
force-pushed
the
feat/cli-keyframes-command
branch
from
d713c33 to
5e8cf5e
Compare
jrusso1020
approved these changes
Jun 18, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 74c37f3a per Rames D Jusso + Via stack review. GSAP runtime read layer + shared helpers — focused, isolated, no concerns.
Reminder: PR body is the unfilled template (stack-wide process flag from Rames D Jusso + Via); please fill in before merge.
miguel-heygen
force-pushed
the
feat/cli-keyframes-command
branch
from
5e8cf5e to
f6a0cbb
Compare
miguel-heygen
force-pushed
the
feat/studio-gsap-read-layer
branch
from
74c37f3 to
52dfaa9
Compare
jrusso1020
approved these changes
Jun 18, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Re-approved at 52dfaa9e post-restack. GSAP runtime read layer unchanged in substance; clean.
readRuntimeKeyframes skips zero-duration hf-hold sets and picks the first real timeline; shared tween/selector helpers, tween cache, and fetch fallback.
miguel-heygen
force-pushed
the
feat/studio-gsap-read-layer
branch
from
52dfaa9 to
06aecb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: GSAP keyframe + motion-path editing — studio runtime read layer (#1553 → #1561).
What
A read layer that reads live GSAP keyframes / motion-paths from the preview iframe runtime, plus shared time helpers, a parsed-animation fetch fallback, and a per-element tween cache.
Why
The static parser can't always resolve keyframes (data-driven loops, computed selectors, fetched values). Reading the live
__timelinesruntime fills the gap; a cold-parse fetch fallback covers the initial-load race where the parse endpoint isn't warm yet.How
gsapRuntimeKeyframes.ts:readRuntimeKeyframes/scanAllRuntimeKeyframesread the live timeline (skipping zero-duration holdsets).gsapShared.ts: tween-relative ↔ clip-relative percentage conversion.useGsapAnimationFetchFallback.ts: retry the parse endpoint on a cold read.useGsapTweenCache.ts: memoize parsed animations per element.Test plan
bun run test(studio) green