Skip to content

fix(web-transport-moq): acknowledge close capsules before teardown (1.3) - #42

Closed
kixelated wants to merge 1 commit into
release/1.3from
fix/close-acked-1.3
Closed

kixelated wants to merge 1 commit into
release/1.3from
fix/close-acked-1.3

Conversation

@kixelated

Copy link
Copy Markdown

Backport of #40 to 1.3, for moq-dev/moq's release branch, which pins web-transport-moq 1.3.x.

The close task now waits for the CONNECT stream's capsule DATA and FIN to be acknowledged before starting the 100 ms teardown grace, so a refused browser session sees code 2 unauthorized instead of "Connection lost" when packets are lost or the socket stalls. A peer STOP or transport termination ends the wait. Cherry-picked cleanly (-x).

Both regressions, close_waits_for_capsule_ack and close_ack_wait_ends_with_connection, pass on this branch and fail without the fix (closed before the capsule was acknowledged). cargo test -p web-transport-moq and clippy with -D warnings pass locally.

Public API: none; only the Tokio dev dependency gains test-util for mocked time. Wire: none; the existing CLOSE capsule is delivered, not changed.

After this merges, a 1.3.6 release PR and v1.3.6 tag publish it.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-authored-by: GPT-6 <noreply@openai.com>
(cherry picked from commit e27c0ce)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T02:25:38.841480Z 6620df0 PR opened
🔒 Security Review ✅ Completed 2026-10-17T02:28:01.146699Z 6620df0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated mentioned this pull request Oct 17, 2026
@kixelated kixelated closed this Oct 17, 2026
@kixelated kixelated reopened this Oct 17, 2026
kixelated added a commit to moq-dev/moq that referenced this pull request Oct 17, 2026
Delete once web-transport-moq 1.3.6 is on crates.io (moq-dev/noq#42, #43).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Author

Closing: the release line will not be patched. The next MoQ release cut from main carries the acknowledged-close fix through moq-tokio, so 1.3.6 is not needed.

(Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant