Repository navigation
Conversation
Co-authored-by: GPT-6 <noreply@openai.com> (cherry picked from commit e27c0ce)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closed
kixelated
added a commit
to moq-dev/moq
that referenced
this pull request
Oct 17, 2026
Delete once web-transport-moq 1.3.6 is on crates.io (moq-dev/noq#42, #43). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Closing: the release line will not be patched. The next MoQ release cut from main carries the acknowledged-close fix through moq-tokio, so 1.3.6 is not needed. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #40 to 1.3, for moq-dev/moq's
releasebranch, which pinsweb-transport-moq1.3.x.The close task now waits for the CONNECT stream's capsule DATA and FIN to be acknowledged before starting the 100 ms teardown grace, so a refused browser session sees code 2
unauthorizedinstead of "Connection lost" when packets are lost or the socket stalls. A peer STOP or transport termination ends the wait. Cherry-picked cleanly (-x).Both regressions,
close_waits_for_capsule_ackandclose_ack_wait_ends_with_connection, pass on this branch and fail without the fix (closed before the capsule was acknowledged).cargo test -p web-transport-moqand clippy with-D warningspass locally.Public API: none; only the Tokio dev dependency gains
test-utilfor mocked time. Wire: none; the existing CLOSE capsule is delivered, not changed.After this merges, a 1.3.6 release PR and
v1.3.6tag publish it.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code