Skip to content

Write down the steward's PR process and chip's advisory review - #33

Merged
chip-peanut-bot[bot] merged 2 commits into
mainfrom
docs/steward-pr-process
Sep 30, 2026
Merged

chip-peanut-bot[bot] merged 2 commits into
mainfrom
docs/steward-pr-process

Conversation

@chip-peanut-bot

Copy link
Copy Markdown
Contributor

This adds Hugo's 2026-09-30 process to CLAUDE.md, under Shipping. AGENTS.md is a symlink to that file, so it gets the same text.

  • The steward never pushes to main; Konrad and Hugo still can. Each steward change goes branch → PR → chip review → steward QA → steward merges, with no human approval needed.
  • chip reviews every non-draft PR automatically, in advisory mode. It takes about 5–10 minutes, and commenting /chip review asks for another pass.
  • Before merging, the steward reads chip's reviews and comments. It fixes or replies to each finding, and never merges with an unanswered blocking or major finding.
  • .github/workflows/chip-pr-review.yml must stay byte-identical to mono's copy, so any change to it is made in mono.

The change is docs only. This is the first PR to go through the new process.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BbTFsJ6NvdFt4NG4UJG57m

Hugo's rule from 2026-09-30: the steward no longer pushes to main. It opens a
PR, waits for chip's review, answers or fixes every finding, runs its own QA,
then merges. Kept in this file (AGENTS.md is a symlink to it) so the rule
survives steward restarts. Also records that the chip review workflow is owned
by mono and must not be edited here.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 88f15206-c068-450f-9766-bee880c295fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No findings in the four-line process-documentation change.

Checked clean

  • CLAUDE.md process wording, AGENTS.md symlink, and the mono-owned review workflow copy match the stated process.
  • CI check fails on formatting of unchanged .github/workflows/chip-pr-review.yml; the failure is present outside this PR diff. Other completed checks passed.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Exact head: f47f6a1d8768 · Context: repo, mono · Took 3m (queued 2m)

@chip-peanut-bot
chip-peanut-bot Bot merged commit da48244 into main Sep 30, 2026
11 checks passed
@chip-peanut-bot
chip-peanut-bot Bot deleted the docs/steward-pr-process branch September 30, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants