fix: best-effort dismiss of Background Payments intro sheet - #234
Open
piotr-iohk wants to merge 2 commits into
Open
piotr-iohk wants to merge 2 commits into
piotr-iohk wants to merge 2 commits into
Conversation
This was referenced Sep 18, 2026
Hard-waiting on BackgroundPaymentsIntro-later flakes the Android send shard when the timed sheet is already gone or auto-dismissed. Poll like waitForToastBestEffort and still dismiss Later/Cancel when the intro is shown. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/1177-electrum-error-toasts
branch
from
September 18, 2026 16:44
9bffffc to
e36d4a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Rebased onto latest
mainafter #233 (settings toast soft-wait) and #235 (iOS Background Payments dismiss) landed. The only remaining unique change is softeningdismissBackgroundPaymentsTimedSheetso a missing/auto-dismissed intro sheet does not fail the Android send shard.Companion app branch:
fix/1177-electrum-error-toasts(bitkit-android#1287).Why
Android product PR synonymdev/bitkit-android#1287 failed only on
e2e-tests-local - send:https://github.com/synonymdev/bitkit-android/actions/runs/35343510496
dismissBackgroundPaymentsTimedSheethard-waited onBackgroundPaymentsIntro-laterand timed out 3/3 (@send_2, 30s). Other local shards were green.E2E_BRANCHresolved tomain.Change
Same helper as clean #241. Soften
dismissBackgroundPaymentsTimedSheetto awaitForToastBestEffort-style poll:triggerTimedSheetUnlessPresentso we do not HeaderMenu-trigger over an already-visible sheet.Conflict resolution: took this PR’s best-effort poll and dropped
main’s leftover hard-wait body from #235. Did not re-apply settings toast soft-wait (already onmainvia #233).Test plan
eslint+tsc --noEmitontest/helpers/actions.tse2e-tests-local - sendon android#1287 after this rebase (no emulator in this environment)