Repository navigation
Reuse sorted edge projections and completed rectangle expansion searches - #164
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
marked this pull request as ready for review
October 19, 2026 10:42
| } | ||
| blockerIndex.finish() | ||
| } | ||
| const queryBlockers = ( |
Contributor
There was a problem hiding this comment.
just some handbook compliance cleanup
This was referenced Oct 20, 2026
0hmX
approved these changes
Oct 20, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligned edges previously repeated blocker clipping and sorting after each spatial lookup. This change shares sorted projections per exact line, reuses completed rectangle-expansion queries, maintains full-stack blockers incrementally, and avoids allocating layer intersections for rectangles that do not overlap. Edge tasks use traversal ordinals so shared work preserves the original candidate precedence and float representation.
Rectdiff-only solve measurements at
d3a8b09:215284cd3a8b09Local Linux x64, Bun 1.3.14, same host and inputs,
RectDiffPipelinewithmaxGapFillPasses: 4. One warmup per revision, then two ABBA cycles: four measured passes per revision. Values are means of summedsolve()time across each workload. Input cloning, explicit GC and output hashing are outside the timed solve; every pass verifies the complete ordered mesh JSON hash.Board109 uses fresh-process full Pipeline9 ABBA runs on the same Linux x64 host, Bun 1.3.14, effort 1 and
cacheProvider: null: two processes per revision. All four complete routed-JSON hashes match, with all 349 endpoint pairs routed, 349 traces, 414 vias and zero relaxed DRC errors. Each process audits its input, resolved rectdiff source and Git revisions.Validation at
d3a8b09:215284cdependency for all 127 dataset01/18/24 boards plus board109.Consumer PR3135 pins this revision at
2a436ee. Final same-machine Pipeline9 benchmarks were run after all CI checks passed: dataset01, dataset18, dataset24. Topology time is lower by 10.6%, 21.3% and 27.0%, respectively, with zero routing-outcome changes. Because topology accounts for roughly 1–2% of the latter datasets, those gains produce much smaller overall-routing changes. Dataset24 still has its existing seven timeouts and two DRC issues.Full-pipeline RAM results are mixed. Dataset24's final P50/P80/P90 peak RSS improve 4.8%/1.5%/4.8%, but dataset18 P50 increases 6.9%, and dataset24 sample 010 increases 679.3→775.7 MiB (+14.2%) in the official ARM run. Separate fresh-process ABBA checks under Bun 1.4.2/x64 preserve identical routes and measure about 2.6% higher mean peak RSS for samples 010 and 020; the larger gaps appear downstream after topology. Source review found no new persistent cache/index retention path, but does not establish the cause. These measurements remain a limitation: no universal memory-parity or per-board overall-time claim is made.