Skip to content

Prevent stale temporal history after camera cuts - #163

Draft
proggeramlug wants to merge 1 commit into
codex/windows-gpu-cifrom
codex/windows-camera-cut
Draft

Prevent stale temporal history after camera cuts#163
proggeramlug wants to merge 1 commit into
codex/windows-gpu-cifrom
codex/windows-camera-cut

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

After a camera cut, TAA still sampled the previous history epoch even when the CPU requested current-only output. Stale confidence could activate settled-history locks. A 40-frame old-camera control leaves visible residue at roughly 16,900 pixels on Vulkan and DX12, with maximum channel error 232; the original eight-frame DXC case also has a one-byte mismatch.

Apply the existing history-usable predicate before reading old color or provenance. Reset and bootstrap frames retain current-frame defaults and zero confidence; valid accumulation keeps its existing policy. Extend the exact-equality camera-cut regression to both eight and 40 history frames, preserving its later FOV/rotation/pan checks and every threshold. The golden device helper now honors explicit shader compiler options.

Validation: unchanged-shader controls retain their failures. With the guard, all six fresh/reset capture pairs are byte-identical across Vulkan, DX12/FXC and DX12/DXC; each backend's initial fresh image is unchanged. The complete local shared CI component passes under DX12/DXC and Vulkan: 489 library tests, device negotiation, 93 goldens and the remaining integration checks. Formatting, strict Clippy policy, repository contracts and diff checks pass. Existing ignored tests remain ignored. See the report.

Stacked on #162; advances #135/#149/#140. Hosted Tests run 34550069181 completes with 21 successful jobs and one failed Windows shared job. The actual Windows native build and all 20 native example links pass; macOS shared tests pass all 93 goldens, including the expanded camera-cut test. Canonical Metal captures and quality contracts pass. Windows shared tests still crash with 0xc0000005 in the library stage before goldens; this remains a separate compatibility investigation. Named full-hardware quality jobs are skipped.

Published evidence contains the original failures, all six exact RGBA comparisons, complete local and hosted logs, source-match receipts and example link evidence. ZIP SHA-256: c03b55eafd7c8d2cf17c08c958440395d4aa65fd37f9beeef1241a53e247d4d7. No full hardware/performance acceptance or merge is claimed.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant