Skip to content

Preserve animated zoom across semantic LOD transitions - #207

Merged
mvalancy merged 2 commits into
devfrom
fix/lod-transition-ownership-20261027
Oct 27, 2026
Merged

mvalancy merged 2 commits into
devfrom
fix/lod-transition-ownership-20261027

Conversation

@mvalancy

@mvalancy mvalancy commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Animated zoom could stop just above the overview exit threshold instead of reaching its target. Title remeasurement called D3's camera transform and interrupted the active animation. It now refreshes source-title geometry at the current scale without issuing camera commands.

Fixes #205. The correction is based on fixture-maintenance PR #204, now merged to dev. No shared CodeGraph library or dependency change.

Validation at b12d08357b70f5f9b83c9eb0b84d6d411ccdab3c:

  • The animation regression explicitly observes overview exit between scales 1.15 and 1.2. Original runtime fails at 1.1767031700493764; the fix reaches the requested 1.2.
  • Late review found the first patch selected a nonexistent .main-group. Its earlier geometry-only pass and review clearance were withdrawn. The final patch targets the actual .main-graph-group.
  • A second, paused-clock phase observes native getBBox on the real title after visibility changes. It requires a visible measurement, bounded geometry, exactly unchanged camera and zero camera publications. Wrong-selector negative fails at zero visible measurements; corrected desktop/phone LOD journeys pass 2/2 in 4.2 minutes, one worker and zero retries. Earlier failures and traces are retained.
  • Unchanged original patch gates: web 346/346, harness 175/175, build/types/lint, user smoke 6/6. Renewed independent exact-head review found no remaining findings. Final CI 40601620456 is running; Comprehensive 40601620282 passed. Pending checks are not counted as passes.

Current dev post-merge CI 40597120363 failed this same pre-correction LOD transition. Corrective integration and successful post-merge CI are required before #203/#205 closeout. Independent agent review is not a GitHub non-author approval.

This fixes transition ownership and title refresh; multilevel grouping, bounded 1k rendering, progressive 10k loading and hosted acceptance remain unfinished. No deployment is claimed.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

Follow-up independent review found a missed selector mismatch in a6fdec6: the title-only effect selected .main-group, but the actual renderer owns .main-graph-group. Its animation regression and final CI passed because later zoom frames refitted the labels. That evidence did not prove fixed-camera refresh, so the relevant clearance is withdrawn and this PR stays unmerged.

A fixed-camera Overview→Items control now observes the real visible title getBBox measurement, retains geometry checks, and requires zero camera publication with the clock paused. The incorrect selector fails with zero visible measurements; a geometry-only draft had passed and is explicitly not counted as a negative control. The selector correction and strengthened desktop/phone acceptance are running locally. The updated exact head will receive renewed review and CI before integration.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

Final preflight for native dev-only integration: source b12d08357b70f5f9b83c9eb0b84d6d411ccdab3c; live dev 8419292ff4c6d015262ec3b319407863de1057d2. Dev's complete tree 2256332a250c534b2bcd322c1c027acfb71c2688 is identical to reviewed source base 7fe08c5; the complete four-path feature diff remains independently reviewed, with no authority changes. Expected resulting tree: be00a67a1cdc13a9af50d33c5cc94835297eb1af.

Final CI and Comprehensive suite succeeded. Every applicable job/step passed, including Node22/24, installer, installed dependencies, build/types/lint, security, real Neo4j and showcase. The main/nightly-only production job is correctly inapplicable to this dev PR.

Actual downloaded strict evidence: smoke6, new-user42, semanticLOD2, routes7, mobile27, performance3; every case passed, no warnings/skips/evidence errors/timeouts or nonzero executions. The living-effects browser step also passed. Prior local negative controls and the late selector correction are retained and independently reviewed at this exact head.

This uses the owner's standing dev administrator integration authorization; independent agent review is not a GitHub non-author approval. The current dev post-merge failure40597120363 is the known pre-correction LOD interruption, so #203/#205 closeout remains pending corrective post-merge CI. No main, release, deployment, identity or protection changes are included.

@mvalancy
mvalancy merged commit 0888279 into dev Oct 27, 2026
16 checks passed
@mvalancy

Copy link
Copy Markdown
Member Author

Native dev admin integration completed: 088827939cd93853c4aa5af82ae41b99df7c19a8. Verified parents are previous dev 8419292ff4c6d015262ec3b319407863de1057d2 and reviewed source b12d08357b70f5f9b83c9eb0b84d6d411ccdab3c; complete resulting tree be00a67a1cdc13a9af50d33c5cc94835297eb1af is identical to the reviewed/tested source.

Post-merge CI40604945011 and Comprehensive40604945017 are queued/running. #203/#205 remain open until corrective dev validation completes. Prior failure40597120363 remains retained. No claim of main promotion, publication or deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant