[kixelated]

Finishes quest/m1/api-audit/net-exports.md, the follow-up to moq-dev/moq#6470: the moq-net, @moq/net, and moq-ffi items with no consumer outside tests go private, test-only, or away. Tests that used them now poll what remains.

Changes

• Epoch time: Epoch::time, FFI moq_epoch_time_ms, and the wrappers in every binding are removed (Python epoch_time, Swift/Kotlin/Dart epochTime, Go EpochTime, C++ epoch_time). The Dart bindings are regenerated. Binding tests now check the invalid-epoch refusal through announce. moq_mint_epoch stays.
• Sync: announce::Consumer::is_synced is now #[cfg(test)] and announce::Consumer::synced is removed. Integration tests and benches call poll_synced.
• Dead code removed: Error::TooManyParameters, DecodeError::{ExpectedData, Missing, Unsupported}, frame::Consumer::poll_read_all (now inlined into read_all), track::Ordered::poll_finished, Path::next_part, stats::Registry::exclude, stats::Traffic::{is_announced, total_bytes}, stats::Tier::is_default, setup::Token::CAT. In JS: Varint.sizeLeadingOnes, SetupOptions.{removeBytes, removeVarint}, the deliveryTimeout accessors, and Epoch.time, which mirrors the Rust removal.
• Test-only plumbing removed:
  • broadcast::Demand and both demand() getters, plus the loom and integration assertions that only exercised them.
  • goaway::Consumer::{peek, recv}. Callers poll the consumer; the moq-net integration support has a small Draining trait.
  • bandwidth::Producer::{abort, closed}. Its write-only abort field goes too.
  • Version::{names, from_alpn, is_ietf}. Tests list versions with Version::from_code over the wire-code ranges.
  • Server::with_origin, stats::Handle::{parent, tier}, and group Producer::{poll_unused, abort_unused}.
• Narrowed: varint::MAX_QUIC is pub(crate). JS Group.Demand/demand() and ConnectProps/AcceptProps.extensions are @internal.
• Doc and fact fixes: rs/AGENTS.md now uses track::Demand as its example lifecycle watcher, and rs/moq-net/AGENTS.md no longer mentions is_ietf(). MIGRATE entries were added for moq-net and @moq/net. Three quests that linked here were updated.

Choices made unattended (review these)

• Kept despite the plan: the plan listed some of these as having no consumer, but building every target found real users.
  • transport::poll::Buffered::get_mut: the shared mock harness reads below the buffering, in integration tests and benches.
  • bandwidth::Producer::{used, unused}: the wasm-only moq-ffi dialer (session/dial.rs) awaits them.
  • frame::Buffer::{is_full, filled_mut}: group::Consumer::poll_read_frames and read_frames use them, so they are pub(crate) rather than deleted.
• JS Epoch.time is also removed, so the two languages stay mirrored. It was unreleased and only tests read it. The shared epoch.json vectors drop unix_ms.
• A version list for tests comes from Version::from_code over 0xff0dad00..=0xff0dadff and 0xff000000..=0xff0000ff. This avoids hardcoding the -wip name. The CLI help tests in moq-cli and moq-tokio use the same approach.

Impact

• Public API: breaking removals in moq-net, @moq/net, moq-ffi, and every binding wrapper. Migration notes are in rs/moq-net/MIGRATE.md and js/net/MIGRATE.md. The epoch-time removals were never released, so they have no entry. Only moq_mint_epoch remains.
• Wire: none.

Checks

• just check passes: 8898 Rust tests, Python and JS tests, and kt, swift, go, cpp, dart, and obs checks.
• just fix includes the wasm build.
• cargo check --all-targets --all-features passes on the touched crates.
• Not run: just rs loom (two loom models were deleted, the rest untouched), the binding test suites beyond check, and the interop lane (no wire change).

Follow-ups

• RecvBandwidth::poll in moq-tokio still handles a closed output, but out can no longer close while the call borrows it. The arm can go if that stays true.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8c6b6164-62cc-4622-ac48-2eb084999159

Commits

Reviewing files that changed from the base of the PR and between 4ab968a and 70ea1f6.

Files selected for processing: 86

• cpp/moq/include/moq/moq.hpp
• cpp/moq/test/probe.cpp
• dart/moq/lib/src/epoch.dart
• dart/moq/test/moq_test.dart
• dart/moq_ffi/lib/src/moq.dart
• go/wrapper/moq_test.go
• go/wrapper/types.go
• js/net/MIGRATE.md
• js/net/api/index.api.md
• js/net/api/zod.api.md
• js/net/src/connection/accept.ts
• js/net/src/connection/connect.ts
• js/net/src/epoch.test.ts
• js/net/src/epoch.ts
• js/net/src/group.ts
• js/net/src/ietf/parameters.ts
• js/net/src/ietf/setup_options.ts
• js/net/src/varint.ts
• kt/moq/src/jvmAndAndroidMain/kotlin/dev/moq/Epoch.kt
• kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt
• py/moq-rs/docs/index.md
• py/moq-rs/moq/__init__.py
• py/moq-rs/moq/epoch.py
• py/moq-rs/tests/test_local.py
• quest/m1/api-audit/README.md
• quest/m1/api-audit/net-exports.md
• quest/m1/api-audit/net-names.md
• rs/AGENTS.md
• rs/moq-cli/src/args.rs
• rs/moq-cli/tests/integration/listen.rs
• rs/moq-ffi/src/bandwidth.rs
• rs/moq-ffi/src/origin.rs
• rs/moq-ffi/src/test.rs
• rs/moq-net/AGENTS.md
• rs/moq-net/MIGRATE.md
• rs/moq-net/benches/session.rs
• rs/moq-net/benches/synced.rs
• rs/moq-net/src/auth.rs
• rs/moq-net/src/coding/decode.rs
• rs/moq-net/src/coding/varint.rs
• rs/moq-net/src/epoch.json
• rs/moq-net/src/epoch.rs
• rs/moq-net/src/error.rs
• rs/moq-net/src/fuzz.rs
• rs/moq-net/src/goaway.rs
• rs/moq-net/src/ietf/session.rs
• rs/moq-net/src/ietf/subscriber.rs
• rs/moq-net/src/model/bandwidth.rs
• rs/moq-net/src/model/broadcast.rs
• rs/moq-net/src/model/frame.rs
• rs/moq-net/src/model/group.rs
• rs/moq-net/src/model/origin.rs
• rs/moq-net/src/model/track.rs
• rs/moq-net/src/path/mod.rs
• rs/moq-net/src/server.rs
• rs/moq-net/src/session.rs
• rs/moq-net/src/setup.rs
• rs/moq-net/src/stats.rs
• rs/moq-net/src/version.rs
• rs/moq-net/tests/integration/auth.rs
• rs/moq-net/tests/integration/goaway.rs
• rs/moq-net/tests/integration/lazy_discovery.rs
• rs/moq-net/tests/integration/rejoin.rs
• rs/moq-net/tests/integration/stream_credit.rs
• rs/moq-net/tests/integration/support/mod.rs
• rs/moq-net/tests/integration/synced.rs
• rs/moq-net/tests/integration/track_stream_demand.rs
• rs/moq-net/tests/integration/unannounce_release.rs
• rs/moq-net/tests/loom.rs
• rs/moq-relay/src/shutdown.rs
• rs/moq-relay/src/web.rs
• rs/moq-relay/src/websocket.rs
• rs/moq-relay/tests/integration/auth_lifetime.rs
• rs/moq-relay/tests/integration/goaway_cluster.rs
• rs/moq-relay/tests/integration/runtime_uring.rs
• rs/moq-relay/tests/integration/shutdown_signal.rs
• rs/moq-stats/src/aggregate.rs
• rs/moq-stats/src/produce.rs
• rs/moq-tokio/src/client.rs
• rs/moq-tokio/src/connection.rs
• rs/moq-tokio/src/server.rs
• rs/moq-tokio/src/websocket.rs
• rs/moq-tokio/tests/integration/broadcast.rs
• rs/moq-transcode/src/active.rs
• swift/Sources/Moq/Epoch.swift
• swift/Tests/MoqTests/SmokeTests.swift

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T21:20:11.623151Z	70ea1f6	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[kixelated]

Automated review by review (OpenAI)

Reviewed commit: ccfd7f4

No actionable bugs found. The direction is coherent: removing unused surface area rather than preserving redundant wrappers. The inspected Rust polling replacements preserve recovery/closure behavior, current protocol variants remain covered by the migrated enumeration tests, and the epoch API removal is aligned across the FFI and language wrappers.

Verification limits: static GitHub review of the changes and relevant surrounding code only. I did not run builds, tests, binding generation, or interoperability checks.

[kixelated]

Maintainer decisions (2026-10-25):

• Deleting broadcast::Demand is confirmed.
• group::Demand has no production consumer, so delete it rather than convert it.
• The rest of the used/unused to wanted change is planned in api-audit/wanted (moq-dev/moq#6798).

(Written by Claude Opus 5.5)

[kixelated]

Merged main twice and resolved:

• group::Producer::abort_unused (made pub(crate) on main pending this audit), Tier::is_default, and Version::{names, from_alpn} stay removed; main had dropped Tier::track_name meanwhile.
• The moq-relay and moq-tokio qmux pin tests now list draft 18 and 22 by wire code, since moq-dev/moq#6754 dropped drafts 19-21.
• Dropped the Kotlin Duration/Instant imports both sides no longer use, and refreshed the @moq/net API reports for the now-@internal extensions.

just check (rs, py, kt, swift, go, cpp, obs_compile, js, dart, quest; flake skipped in this sandbox) and quest check --base origin/main pass. Codex covered d01a6d8; the last merge was mechanical. Landing.

(Written by Claude Opus 5.5)

[kixelated]

Dropped from the queue on a main conflict after moq-dev/moq#6749 landed. Merged main: kept both moq-net MIGRATE entries and accepted the deletion of ietf-private.md (its exceptions moved into the api-audit README, which already says dead errors go). Mechanical; just check and quest check --base origin/main pass on 70ea1f6. Re-landing.

(Written by Claude Opus 5.5)