Skip to content

net: preserve exact aggregate diagnostic facts in summary contracts - #772

Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
phealy/lightweight-status-diagnostic-rulesfrom
phealy/lightweight-status-diagnostic-contract
Closed

Patrick W. Healy (phealy) wants to merge 1 commit into
phealy/lightweight-status-diagnostic-rulesfrom
phealy/lightweight-status-diagnostic-contract

Conversation

@phealy

@phealy Patrick W. Healy (phealy) commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Scope

Stacked on #771. Adds scalar route mismatch count, unhealthy peer-link count, and IPIP-use facts to shared/protobuf overviews, preserving detailed diagnostic meaning without peer/route arrays. Maintains the correlated DetailError field from the preceding stack.

171 changed LOC, including generated bindings and contract coverage.

Validation

Shared status race tests passed, including detail-error and aggregate diagnostic round trips. Pinned protobuf regeneration was idempotent after merging both schema additions.

Lightweight status draft stack

Base: #745. Each layer targets the preceding branch and remains draft.

#746 -> #747 -> #748 -> #750 -> #751 -> #752 -> #753 -> #754 -> #755 -> #756 -> #757 -> #758 -> #759 -> #760 -> #761 -> #762 -> #763 -> #764 -> #765 -> #766 -> #767 -> #768 -> #769 -> #770 -> #771 -> #772 -> #773 -> #774 -> #775 -> #776 -> #777 -> #778 -> #779 -> #780 -> #781 -> #782 -> #783 -> #784 -> #785 -> #786 -> #787 -> #788 -> #789 -> #790 -> #791 -> #792 -> #793 -> #794 -> #795 -> #796 -> #797 -> #798 -> #799

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
@phealy

Copy link
Copy Markdown
Contributor Author

This PR was mistaken churn from splitting the lightweight-status work into unnecessarily small PRs. That was my mistake, not a requirement from the user.

Its changes are preserved in #812 within the user-approved, consolidated 12-PR draft stack. Closing this superseded PR; the implementation is not being discarded, and nothing has been merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant