net dashboard: fix browser timers preventing Load data requests - #797
Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
Patrick W. Healy (phealy) wants to merge 1 commit into
Conversation
Wrap native timer calls instead of invoking them with the detail clock as their receiver. This prevents Illegal invocation before the initial diagnostic POST. Exercise the actual dialog and hook under Chromium StrictMode with same-origin HTTP, polling, refresh failures, expiry, deadlines, cancellation and unmount cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
This was referenced Sep 17, 2026
This was referenced Sep 17, 2026
Contributor
Author
|
This PR was mistaken churn from splitting the lightweight-status work into unnecessarily small PRs. That was my mistake, not a requirement from the user. Its changes are preserved in #764, #766 within the user-approved, consolidated 12-PR draft stack. Closing this superseded PR; the implementation is not being discarded, and nothing has been merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix native Window timer receiver binding in the detail lifecycle clock. Calling browser timers as methods of the custom clock threw Illegal invocation before the diagnostic POST, so Load data failed despite the backend and CLI working.
Based on #796. Includes an optional real Chromium regression exercising dialog buttons, POST/GET polling, refresh, expiry, timeout, StrictMode, and cleanup. No production dependency added.
Validation: 22 frontend unit tests, TypeScript, Vite build, and native Chromium test passed on the integrated branch. Agent also verified live pr712 POST 202 -> GET 200 -> rendered details for one node. Draft, 188 added+deleted lines.
Lightweight status draft stack
Base: #745. Each layer targets the preceding branch and remains draft.
#746 -> #747 -> #748 -> #750 -> #751 -> #752 -> #753 -> #754 -> #755 -> #756 -> #757 -> #758 -> #759 -> #760 -> #761 -> #762 -> #763 -> #764 -> #765 -> #766 -> #767 -> #768 -> #769 -> #770 -> #771 -> #772 -> #773 -> #774 -> #775 -> #776 -> #777 -> #778 -> #779 -> #780 -> #781 -> #782 -> #783 -> #784 -> #785 -> #786 -> #787 -> #788 -> #789 -> #790 -> #791 -> #792 -> #793 -> #794 -> #795 -> #796 -> #797 -> #798 -> #799