net controller: expire viewer detail writes and lifecycle observers - #791
Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
Conversation
Retire automatic detail subscriptions. Route explicit viewer requests through the shared manager and queue only metadata; resolve payloads when writing, with expiry and leadership cancellation. Cancel superseded observers without affecting shared requests. Keep source metadata consistent and require thin storage before the manager starts, closing the startup retention window. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
Contributor
Author
|
This PR was mistaken churn from splitting the lightweight-status work into unnecessarily small PRs. That was my mistake, not a requirement from the user. Its changes are preserved in #788 within the user-approved, consolidated 12-PR draft stack. Closing this superseded PR; the implementation is not being discarded, and nothing has been merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete explicit viewer request notifications using metadata-only queues. Resolve payloads only when writing, cancel detailed writes at snapshot expiry or leadership loss, and release watchers on expiry, replacement, and disconnect. Reject retired automatic subscriptions without collection.
Compatibility
Based on #790. One viewer cannot trigger cluster-wide detail fanout or cancel another viewer’s shared request. Routine updates, global history, and source changes never own or renew diagnostic payloads. Legacy base and UID lifecycle cleanup remain TTL-bound.
Validation
Full controller/shared-status race suites and scoped formatting/lint passed. Tests cover unrelated viewers, metadata-only queues, stale queued completion after expiry, cancellation, leadership loss, fixed display expiry, and refresh replacement. Immediate-parent diff: 750 added+deleted lines.
Part of the draft lightweight-status stack based on #745. Node publishing default activation follows separately.
Lightweight status draft stack
Base: #745. Each layer targets the preceding branch and remains draft.
#746 -> #747 -> #748 -> #750 -> #751 -> #752 -> #753 -> #754 -> #755 -> #756 -> #757 -> #758 -> #759 -> #760 -> #761 -> #762 -> #763 -> #764 -> #765 -> #766 -> #767 -> #768 -> #769 -> #770 -> #771 -> #772 -> #773 -> #774 -> #775 -> #776 -> #777 -> #778 -> #779 -> #780 -> #781 -> #782 -> #783 -> #784 -> #785 -> #786 -> #787 -> #788 -> #789 -> #790 -> #791 -> #792 -> #793 -> #794 -> #795 -> #796 -> #797 -> #798 -> #799