net CLI: retrieve named node diagnostics with explicit refresh - #785
Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
Closed
Patrick W. Healy (phealy) wants to merge 1 commit into
Patrick W. Healy (phealy) wants to merge 1 commit into
Conversation
Keep raw node JSON and existing detail renderers. Completion never collects diagnostics; direct users to node list --watch rather than continuously collecting detail snapshots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
Contributor
Author
|
This PR was mistaken churn from splitting the lightweight-status work into unnecessarily small PRs. That was my mistake, not a requirement from the user. Its changes are preserved in #767 within the user-approved, consolidated 12-PR draft stack. Closing this superseded PR; the implementation is not being discarded, and nothing has been merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Wire named node show commands to the asynchronous detail API, reuse unexpired cache entries by default, and add --refresh for fresh collection. Preserve raw diagnostic JSON and existing show formatting.
Compatibility
Based on #784. Legacy full publications already populate the new detail cache, including nodes unreachable over HTTP. List/watch remain summaries. node show --watch now reports an explicit error directing users to summary list --watch or repeated show --refresh; it does not create continuous detail collection.
Validation
CLI race suite, scoped formatting/lint, and kubectl-unbounded build passed. Immediate-parent diff: 325 added+deleted lines.
Part of the draft lightweight-status stack based on #745. Node publishing default remains full until final controller retention activation.
Lightweight status draft stack
Base: #745. Each layer targets the preceding branch and remains draft.
#746 -> #747 -> #748 -> #750 -> #751 -> #752 -> #753 -> #754 -> #755 -> #756 -> #757 -> #758 -> #759 -> #760 -> #761 -> #762 -> #763 -> #764 -> #765 -> #766 -> #767 -> #768 -> #769 -> #770 -> #771 -> #772 -> #773 -> #774 -> #775 -> #776 -> #777 -> #778 -> #779 -> #780 -> #781 -> #782 -> #783 -> #784 -> #785 -> #786 -> #787 -> #788 -> #789 -> #790 -> #791 -> #792 -> #793 -> #794 -> #795 -> #796 -> #797 -> #798 -> #799