Conversation
Keep the Store trait beside the search index that consumes it. Cache query-independent computed trees under versioned content/settings keys; selected highlights and plugin instances are excluded. AI assistance: reorganized with Codex.
Select backend and location exclusively in Rust configuration. Include shared backend contract, persistence, corruption and config tests. Index lifetime and dependency injection are connected in the search-engine layer above. AI assistance: reorganized with Codex.
sidkmenon
added this pull request to stack #21
September 19, 2026 21:50
sidkmenon
changed the title
This was referenced Sep 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Store beside the search index and supply interchangeable memory, file and SQLite implementations. Backend and path are host configuration only; JavaScript sees no storage runtime. Cached data excludes query highlights and processed visibility.
Review order: #6 → #7 → #20 → #8 → #10 → #13.
Read commit by commit:
c83eab7da— Define the Rust computed-diff storage contract.5141f722d— Implement memory, file and SQLite stores behind host configuration.Verification: the complete rewritten diffr tip has exactly the same Git tree as the previously tested tip (262 Rust tests passed, one ignored; 11 JS tests passed; TypeScript checks and the real pretty-output contract passed). No behavior changes in this rewrite. This replaces the old storage PR #11 after the stack reorder; no change was merged into main.
This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.
AI assistance: authored and reorganized with Codex.