Skip to content

Carry highlighted evidence through the plugin contract and pipeline - #7

Draft
sidkmenon wants to merge 3 commits into
sm/searchfrom
codex/search-highlights
Draft

sidkmenon wants to merge 3 commits into
sm/searchfrom
codex/search-highlights

Conversation

@sidkmenon

@sidkmenon sidkmenon commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Extend SDK/WIT inputs with shared sources, unchanged status and search highlights. Preserve spans through conversions and mutations, then update bundled folding/grouping/summarization behavior. External component plugins must rebuild.

Review order: #6 → #7 → #20 → #8 → #10 → #13.

Read commit by commit:

  1. 6426aea4b — Extend the plugin contract with shared sources and search highlights.
  2. ed6d80628 — Preserve comparison identity and highlights through plugin mutations.
  3. 29db9d04b — Make bundled plugins honor highlighted evidence.

Verification: the complete rewritten diffr tip has exactly the same Git tree as the previously tested tip (262 Rust tests passed, one ignored; 11 JS tests passed; TypeScript checks and the real pretty-output contract passed). No behavior changes in this rewrite.

This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.

AI assistance: authored and reorganized with Codex.

@sidkmenon
sidkmenon added this pull request to stack #9 September 18, 2026 07:33
@sidkmenon sidkmenon changed the title Preserve search highlights through plugin transformations Preserve search highlights through the plugin pipeline Sep 18, 2026
Add Same source inputs, unchanged file status, and leaf search spans. File references retain their separate three-way pairing. External component plugins must rebuild for the WIT change.

AI assistance: reorganized with Codex.
Carry spans through host, SDK, record and WASM conversions and partition them when splitting leaves. Process shared trees once; ordinary diffs retain their existing source representation. Batch the mechanical conversion and constructor updates together.

AI assistance: reorganized with Codex.
Expand context around changes and matches, preserving visible scope boundaries. Keep highlighted deletions open, group shared sources once, and summarize only added unpaired bodies. Include behavior tests and the rebuilt bundled summarizer.

AI assistance: reorganized with Codex.
@sidkmenon
sidkmenon force-pushed the codex/search-highlights branch from 97297a5 to 29db9d0 Compare September 19, 2026 21:49
@sidkmenon
sidkmenon removed this pull request from stack #9 September 19, 2026 21:50
@sidkmenon
sidkmenon added this pull request to stack #21 September 19, 2026 21:50
@sidkmenon sidkmenon changed the title Preserve search highlights through the plugin pipeline Carry highlighted evidence through the plugin contract and pipeline Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant