Conversation
sidkmenon
added this pull request to stack #9
September 18, 2026 07:33
This was referenced Sep 18, 2026
sidkmenon
changed the title
Move the CLI implementation unchanged into the library with a thin binary entry point. Preserve the diffr help name and mark prose examples for library doctests. Keep this mechanical extraction separate from search behavior. AI assistance: reorganized with Codex.
Inject Store into the generic shared index and keep comparison/plugin state in sessions. Validate hits against pinned Git blobs, hydrate complete comparisons with highlights, and postprocess without dropping source sides. Preserve ordinary identical-file fast paths and reuse equivalent processing across display choices. AI assistance: reorganized with Codex.
Run native work on blocking workers and bind JS result helpers over the serialized trees. Render selected display sides, changes, highlights and folds from complete results. Install package dependencies and ignore generated bindings/cache files. AI assistance: reorganized with Codex.
Build the real native binding and run the TypeScript search output test in CI. The contract fixture is introduced earlier in the stack for review before its backing implementation. AI assistance: reorganized with Codex.
sidkmenon
force-pushed
the
codex/code-mode-search
branch
from
September 19, 2026 21:49
6ddaa7c to
183293a
Compare
sidkmenon
removed this pull request from stack #9
September 19, 2026 21:50
sidkmenon
changed the base branch from
codex/search-highlights
to
codex/diff-store
September 19, 2026 21:50
sidkmenon
added this pull request to stack #21
September 19, 2026 21:50
sidkmenon
changed the title
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the earlier search API over pinned Git blobs and complete hydrated comparisons. Plugins receive the original comparison and printing applies display selection afterward. Keep the engine-to-library extraction separate from behavior; then add native workers, JS result helpers, printing and CI.
Review order: #6 → #7 → #20 → #8 → #10 → #13.
Read commit by commit:
ea36cd86a— Extract the existing engine into a shared Rust library.df47a5717— Implement pinned-source indexing and complete-tree hydration.c1b1fe03b— Bind the Rust search engine and print expandable results.183293aa8— Run the native pretty-output integration contract in CI.Verification: the complete rewritten diffr tip has exactly the same Git tree as the previously tested tip (262 Rust tests passed, one ignored; 11 JS tests passed; TypeScript checks and the real pretty-output contract passed). No behavior changes in this rewrite.
This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.
AI assistance: authored and reorganized with Codex.