metrics: split package + stacking decisions hardening#122
Open
FIrgolitsch wants to merge 5 commits into
Open
Conversation
Previously the correlation-fallback branch overwrote the measured NCC with 0.0, making it indistinguishable from a true zero-correlation match and impossible to derive a sensible `z_overlap_min_corr` from stacking_decisions.csv -- every fallback row reported 0.0 regardless of how close the actual measurement was to the threshold. The fallback now keeps the measured correlation and reports `overlap_source = 'correlation_fallback'` (plus a new `correlation_fallback_used` z-match flag) so QC can tell which pairs were trusted vs. demoted to the slicing-interval estimate while still seeing the real NCC distribution. Manually aligned slices are already trusted via the registration branch and do not enter this code path.
This was referenced May 20, 2026
FIrgolitsch
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics package split + stacking decisions hardening
Stacked on pr-r-allen-followups. Refactors the metrics package and tightens the stacking-decisions CSV.
Commits
linumpy.metricsintocore/aggregate/collectorssubmodules.add_paramsandfinalizehelpers.2c37fce0) — preserve the measured Z-overlap correlation when falling back onmin_corr; surface it via a newcorrelation_fallbackvalue in theoverlap_sourcecolumn and a dedicatedcorrelation_fallback_usedflag (instead of zeroing the correlation, which was indistinguishable from a real zero-NCC match).Docs gaps
correlation_fallbackis not yet documented indocs/PIPELINE_OVERVIEW.md/docs/NEXTFLOW_WORKFLOWS.md; follow-up.