fix_illum: pool tiles across Z + darkfield/fit knobs (chain tip = dev)#125
Open
FIrgolitsch wants to merge 2 commits into
Open
fix_illum: pool tiles across Z + darkfield/fit knobs (chain tip = dev)#125FIrgolitsch wants to merge 2 commits into
FIrgolitsch wants to merge 2 commits into
Conversation
…s/max_iterations parameters Squashed from: 92961af perf(fix_illum): pool tiles across Z and enable darkfield for stable flatfield 421281b Revert darkfield defaulting to true 6290675 expose fix_illum_fit_max_samples and fix_illum_max_iterations pipeline params 37f55ce expose fix_illum_darkfield pipeline param to remove residual per-tile waffle 7b0551d Fix darkfield estimation and filtering for illumination correction
This was referenced May 20, 2026
FIrgolitsch
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix_illum: pool tiles across Z + darkfield/fit knobs
Stacked on pr-v-psf-focal. Tip of the chain — equals
dev.Commits
linum_compensate_illumination.pynow pools tiles across Z slices for a more stable flat-field estimate and exposes three new knobs innextflow.config:fix_illum_darkfield(bool) — fit a darkfield termfix_illum_fit_max_samples(int) — cap samples per fit for speedfix_illum_max_iterations(int) — BaSiC solver iteration capDocs gaps
The three new
fix_illum_*params are not yet indocs/NEXTFLOW_WORKFLOWS.md; follow-up doc PR.Chain summary
This is PR 22/22. Merging the full chain into
mainreproducesdevexactly (verified tree-identical).